Skip to content

Commit 85405bb

Browse files
committed
Fix comment in notify_static_method_calls
1 parent 263089c commit 85405bb

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

jbmc/src/java_bytecode/java_bytecode_language.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1205,6 +1205,10 @@ void java_bytecode_languaget::convert_lazy_method(
12051205

12061206
/// Notify ci_lazy_methods, if present, of any static function calls made by
12071207
/// the given function body.
1208+
/// Note only static function calls need to be reported -- virtual function
1209+
/// calls are routinely found by searching the function body after conversion
1210+
/// because we can only approximate the possible callees once all function
1211+
/// bodies currently believed to be needed have been loaded.
12081212
/// \param function_body: function body code
12091213
/// \param needed_lazy_methods: optional ci_lazy_method_neededt interface. If
12101214
/// not set, this is a no-op; otherwise, its add_needed_method function will
@@ -1224,10 +1228,6 @@ static void notify_static_method_calls(
12241228
const auto fn_call = expr_try_dynamic_cast<code_function_callt>(*it);
12251229
if(!fn_call)
12261230
continue;
1227-
// Only support non-virtual function calls for now, if string solver
1228-
// starts to introduce virtual function calls then we will need to
1229-
// duplicate the behavior of java_bytecode_convert_method where it
1230-
// handles the invokevirtual instruction
12311231
const symbol_exprt *fn_sym =
12321232
expr_try_dynamic_cast<symbol_exprt>(fn_call->function());
12331233
if(fn_sym)

0 commit comments

Comments
 (0)