Whitespace change only: reduce indentation by removing block

The previous change was constructed to have minimal code churn, turning
an `else` block into just a scoping block. This commit now removes this
unnecessary block.

Author: tautschnig

src/pointer-analysis/value_set_dereference.cpp

@@ -628,38 +628,36 @@ value_set_dereferencet::valuet value_set_dereferencet::build_reference_to(
       }
     }
 
+    // try to build a member/index expression - do not use byte_extract
+    auto subexpr = get_subexpression_at_offset(
+      root_object_subexpression, o.offset(), dereference_type, ns);
+    if(subexpr.has_value())
+      simplify(subexpr.value(), ns);
+    if(
+      subexpr.has_value() &&
+      subexpr.value().id() != ID_byte_extract_little_endian &&
+      subexpr.value().id() != ID_byte_extract_big_endian)
     {
-      // try to build a member/index expression - do not use byte_extract
-      auto subexpr = get_subexpression_at_offset(
-        root_object_subexpression, o.offset(), dereference_type, ns);
-      if(subexpr.has_value())
-        simplify(subexpr.value(), ns);
-      if(
-        subexpr.has_value() &&
-        subexpr.value().id() != ID_byte_extract_little_endian &&
-        subexpr.value().id() != ID_byte_extract_big_endian)
-      {
-        // Successfully found a member, array index, or combination thereof
-        // that matches the desired type and offset:
-        result.value = subexpr.value();
-        result.pointer = typecast_exprt::conditional_cast(
-          address_of_exprt{skip_typecast(subexpr.value())}, pointer_type);
-        return result;
-      }
-
-      // we extract something from the root object
-      result.value=o.root_object();
+      // Successfully found a member, array index, or combination thereof
+      // that matches the desired type and offset:
+      result.value = subexpr.value();
       result.pointer = typecast_exprt::conditional_cast(
-        address_of_exprt{skip_typecast(o.root_object())}, pointer_type);
+        address_of_exprt{skip_typecast(subexpr.value())}, pointer_type);
+      return result;
+    }
 
-      if(memory_model(result.value, dereference_type, offset, ns))
-      {
-        // ok, done
-      }
-      else
-      {
-        return valuet(); // give up, no way that this is ok
-      }
+    // we extract something from the root object
+    result.value = o.root_object();
+    result.pointer = typecast_exprt::conditional_cast(
+      address_of_exprt{skip_typecast(o.root_object())}, pointer_type);
+
+    if(memory_model(result.value, dereference_type, offset, ns))
+    {
+      // ok, done
+    }
+    else
+    {
+      return valuet(); // give up, no way that this is ok
     }
   }