Rename type2identifier to type_to_partial_identifier

Because the return value of this function does not uniquely identify a
type, it is only used as part of a unique identifier.

Author: thomasspriggs

src/ansi-c/c_typecheck_expr.cpp

@@ -1893,15 +1893,15 @@ void c_typecheck_baset::typecheck_side_effect_function_call(
         /// XXX why are we only looking at the type of the first parameter?
         if(parameters.front().type().id() == ID_pointer)
         {
-          identifier_with_type =
-            id2string(identifier) + "_" +
-            type2identifier(parameters.front().type().subtype(), *this);
+          identifier_with_type = id2string(identifier) + "_" +
+                                 type_to_partial_identifier(
+                                   parameters.front().type().subtype(), *this);
         }
         else
         {
           identifier_with_type =
             id2string(identifier) + "_" +
-            type2identifier(parameters.front().type(), *this);
+            type_to_partial_identifier(parameters.front().type(), *this);
         }
         gcc_polymorphic->set_identifier(identifier_with_type);
 

src/ansi-c/type2name.cpp

@@ -324,7 +324,7 @@ std::string type_name2type_identifier(const std::string &name)
       replace_special_characters(name))));
 }
 
-std::string type2identifier(const typet &type, const namespacet &ns)
+std::string type_to_partial_identifier(const typet &type, const namespacet &ns)
 {
   return type_name2type_identifier(type2name(type, ns));
 }

src/ansi-c/type2name.h

@@ -29,6 +29,6 @@ std::string type2name(const typet &type, const namespacet &ns);
  *   depends.
  * @return An identifying string which can be used as part of a `C` identifier.
  */
-std::string type2identifier(const typet &type, const namespacet &ns);
+std::string type_to_partial_identifier(const typet &type, const namespacet &ns);
 
 #endif // CPROVER_ANSI_C_TYPE2NAME_H