Install goto-cc symlinks correctly

The previous way created symlinks at install time which led to a somewhat
complicated installation logic. Instead, we should just install the symlinks we
already produce at build time.

Author: hannes-steffenhagen-diffblue

src/goto-cc/CMakeLists.txt

@@ -26,9 +26,10 @@ add_if_library(goto-cc-lib jsil)
 add_executable(goto-cc goto_cc_main.cpp)
 target_link_libraries(goto-cc goto-cc-lib)
 
+install(TARGETS goto-cc DESTINATION ${CMAKE_INSTALL_BINDIR})
+
 if(WIN32)
   set_target_properties(goto-cc PROPERTIES OUTPUT_NAME goto-cl)
-  install(TARGETS goto-cc DESTINATION ${CMAKE_INSTALL_BINDIR})
 else()
   add_custom_command(TARGET goto-cc
     POST_BUILD
@@ -40,19 +41,14 @@ else()
     COMMAND "${CMAKE_COMMAND}" -E create_symlink
       goto-cc $<TARGET_FILE_DIR:goto-cc>/goto-ld
     BYPRODUCTS ${CMAKE_BINARY_DIR}/bin/goto-ld)
-  install(TARGETS goto-cc DESTINATION ${CMAKE_INSTALL_BINDIR})
-  install(CODE "execute_process( \
-    COMMAND ${CMAKE_COMMAND} -E create_symlink \
-    goto-cc \
-    \$ENV{DESTDIR}${CMAKE_INSTALL_FULL_BINDIR}/goto-gcc \
-    )"
-  )
-  install(CODE "execute_process( \
-    COMMAND ${CMAKE_COMMAND} -E create_symlink \
-    goto-cc \
-    \$ENV{DESTDIR}${CMAKE_INSTALL_FULL_BINDIR}/goto-ld \
-    )"
-  )
+
+  install(
+    FILES
+      ${CMAKE_BINARY_DIR}/bin/goto-ld
+      ${CMAKE_BINARY_DIR}/bin/goto-gcc
+    DESTINATION
+      ${CMAKE_INSTALL_BINDIR})
+
   # Symlink man page to cbmc man page until a real man page is written
   install(CODE "execute_process( \
     COMMAND ${CMAKE_COMMAND} -E create_symlink \