Avoid unnecessary copy in byte_operators.cpp

hannes-steffenhagen-diffblue · hannes-steffenhagen-diffblue · commit 2f448dc1c12a · 2020-06-29T17:57:33.000+01:00
Without the &amp; we are copying the items we are iterating over which is
unnecessary here.
diff --git a/unit/solvers/lowering/byte_operators.cpp b/unit/solvers/lowering/byte_operators.cpp
@@ -215,7 +215,7 @@ SCENARIO("byte_extract_lowering", "[core][solvers][lowering][byte_extract]")
 
     THEN("byte_extract lowering yields the expected value")
     {
-      for(const auto endianness :
+      for(const auto &endianness :
           {ID_byte_extract_little_endian, ID_byte_extract_big_endian})
       {
         for(const auto &t1 : types)
@@ -366,7 +366,7 @@ SCENARIO("byte_update_lowering", "[core][solvers][lowering][byte_update]")
 
     THEN("byte_update lowering yields the expected value")
     {
-      for(const auto endianness :
+      for(const auto &endianness :
           {ID_byte_update_little_endian, ID_byte_update_big_endian})
       {
         for(const auto &t1 : types)

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,7 @@ SCENARIO("byte_extract_lowering", "[core][solvers][lowering][byte_extract]")`
`215`	`215`
`216`	`216`	`THEN("byte_extract lowering yields the expected value")`
`217`	`217`	`{`
`218`		`- for(const auto endianness :`
	`218`	`+ for(const auto &endianness :`
`219`	`219`	`{ID_byte_extract_little_endian, ID_byte_extract_big_endian})`
`220`	`220`	`{`
`221`	`221`	`for(const auto &t1 : types)`
`@@ -366,7 +366,7 @@ SCENARIO("byte_update_lowering", "[core][solvers][lowering][byte_update]")`
`366`	`366`
`367`	`367`	`THEN("byte_update lowering yields the expected value")`
`368`	`368`	`{`
`369`		`- for(const auto endianness :`
	`369`	`+ for(const auto &endianness :`
`370`	`370`	`{ID_byte_update_little_endian, ID_byte_update_big_endian})`
`371`	`371`	`{`
`372`	`372`	`for(const auto &t1 : types)`