Merge pull request #7592 from NlightNFotis/fix_name_collisions_static_library

Rename object files so that we don't have collisions between different

Author: NlightNFotis

src/libcprover-cpp/add_dependencies.sh

@@ -15,11 +15,44 @@ DESTINATION=$1
 shift
 LIB_LIST=$@
 
+# We need to do the following renaming of object files because of translation
+# unit name collisions which affect linking against the final artefact. For more
+# details, please look at https://github.com/diffblue/cbmc/issues/7586 .
+
+# Create a temporary folder for this script to work in.
+rm -rf add_dependencies_tmp
+mkdir add_dependencies_tmp
+cd add_dependencies_tmp
+
+# The full path of the current "root" directory
+WORKING_DIR=$(pwd)
+
 # For each library to add:
 for lib in ${LIB_LIST}; do
+  # We will unpack and rename all .o of dependent libraries marking them with
+  # their library name to avoid clashes.
+  LIBNAME=$(basename ${lib} .a)
+
+  # Remove previous unpacked folders and create a new fresh one to work in.
+  rm -rf ${LIBNAME}
+  mkdir ${LIBNAME}
+  cd ${LIBNAME}  
+
   # Unpack the library
   ${AR_COMMAND} -x ${lib}
+
+  # Rename all object files in the library prepending "${LIBNAME}_" to avoid
+  # clashes, and move to the "root" folder.
+  for obj in *.o; do
+    mv ${obj} "${WORKING_DIR}/${LIBNAME}_${obj}"
+  done
+
+  # Move back to the working directory.
+  cd "${WORKING_DIR}"
 done
 
 # Append all the unpacked files to the destination library
 ${AR_COMMAND} -rcs ${DESTINATION} *.o
+
+# TODO: See if we need to do some cleanup in order to save cache space for
+# Github actions runners.