Actually test linker script processing

The goto-cc personality does not invoke linker script processing, hence
the tests located in the ansi-c folder were a no-op. Moving them to the
goto-gcc folder showed that they wouldn't work as is, which is also
fixed now:

1) Add -static so as not to generate dynamic linking headers, which
those linker scripts leave no room for.
2) Actually detect failure of linker script parsing by enabling warnings
and testing for them.
3) Make sure ls_parse.py is available on the PATH.
4) Linker scripts aren't supported by Apple's linker.

Author: tautschnig

regression/goto-gcc/CMakeLists.txt

@@ -1,7 +1,13 @@
+if("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin")
+  set(not_gnu_ld -X gnu-ld-only)
+else()
+  set(not_gnu_ld "")
+endif()
+
 # TARGET_FILE (as used in other directories) can't be used with goto-gcc as it
 # isn't marked as an executable (target), which CMake requires. Thus construct a
 # path in the same way the symbolic link is created in the goto-cc directory.
-add_test_pl_tests("$<TARGET_FILE_DIR:goto-cc>/goto-gcc")
+add_test_pl_tests("$<TARGET_FILE_DIR:goto-cc>/goto-gcc" ${not_gnu_ld})
 
 add_custom_command(OUTPUT "${CMAKE_CURRENT_SOURCE_DIR}/archives/libour_archive.a"
     COMMAND "$<TARGET_FILE_DIR:goto-cc>/goto-gcc" -c foo.c
@@ -15,3 +21,11 @@ add_custom_command(OUTPUT "${CMAKE_CURRENT_SOURCE_DIR}/archives/libour_archive.a
 add_custom_target(libour_archive.a ALL
     DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/archives/libour_archive.a"
 )
+
+if(NOT "${CMAKE_SYSTEM_NAME}" STREQUAL "Windows")
+  set_property(
+    TEST "goto-gcc-CORE"
+    PROPERTY ENVIRONMENT
+      "PATH=$ENV{PATH}:$<TARGET_FILE_DIR:goto-cc>"
+  )
+endif()

regression/goto-gcc/Makefile

@@ -9,11 +9,16 @@ test:
 tests.log: ../test.pl
 
 else
+ifeq ($(BUILD_ENV_),OSX)
+  not_gnu_ld = -X gnu-ld-only
+endif
 test: ../../src/goto-cc/goto-gcc
-	@../test.pl -e -p -c ../../../src/goto-cc/goto-gcc
+	@PATH=../../../scripts:$$PATH \
+		../test.pl -e -p -c ../../../src/goto-cc/goto-gcc $(not_gnu_ld)
 
 tests.log: ../test.pl ../../src/goto-cc/goto-gcc
-	@../test.pl -e -p -c ../../../src/goto-cc/goto-gcc
+	@PATH=../../../scripts:$$PATH \
+		../test.pl -e -p -c ../../../src/goto-cc/goto-gcc $(not_gnu_ld)
 
 ../../src/goto-cc/goto-gcc: ../../src/goto-cc/goto-cc
 	@ln -sf goto-cc ../../src/goto-cc/goto-gcc

…on/ansi-c/linker_script_start+end/main.c …/goto-gcc/linker_script_start+end/main.cregression/ansi-c/linker_script_start+end/main.c renamed to regression/goto-gcc/linker_script_start+end/main.c regression/ansi-c/linker_script_start+end/main.c renamed to regression/goto-gcc/linker_script_start+end/main.c

@@ -2,11 +2,13 @@ extern char src_start[];
 extern char src_end[];
 extern char dst_start[];
 
-void *memcpy(void *dest, void *src, unsigned n){
+void *memcpy(void *dest, void *src, unsigned n)
+{
   return (void *)0;
 }
 
-int main(){
+int main()
+{
   memcpy(dst_start, src_start, (unsigned)src_end - (unsigned)src_start);
   return 0;
 }

…ansi-c/linker_script_start+end/script.ld …to-gcc/linker_script_start+end/script.ldregression/ansi-c/linker_script_start+end/script.ld renamed to regression/goto-gcc/linker_script_start+end/script.ld regression/ansi-c/linker_script_start+end/script.ld renamed to regression/goto-gcc/linker_script_start+end/script.ld

@@ -1,9 +1,10 @@
-CORE
+CORE gnu-ld-only
 main.c
--o out.gb -T script.ld -nostdlib
+-o out.gb -T script.ld -nostdlib -static -Wall
 ^EXIT=0$
 ^SIGNAL=0$
 --
+Problem parsing linker script
 ^warning: ignoring
 ^CONVERSION ERROR$
 --

…ansi-c/linker_script_start+end/test.desc …to-gcc/linker_script_start+end/test.descregression/ansi-c/linker_script_start+end/test.desc renamed to regression/goto-gcc/linker_script_start+end/test.desc regression/ansi-c/linker_script_start+end/test.desc renamed to regression/goto-gcc/linker_script_start+end/test.desc

@@ -2,11 +2,13 @@ extern char src_start[];
 extern char src_size[];
 extern char dst_start[];
 
-void *memcpy(void *dest, void *src, unsigned n){
+void *memcpy(void *dest, void *src, unsigned n)
+{
   return (void *)0;
 }
 
-int main(){
+int main()
+{
   memcpy(dst_start, src_start, (unsigned)src_size);
   return 0;
 }

…n/ansi-c/linker_script_start+size/main.c …goto-gcc/linker_script_start+size/main.cregression/ansi-c/linker_script_start+size/main.c renamed to regression/goto-gcc/linker_script_start+size/main.c regression/ansi-c/linker_script_start+size/main.c renamed to regression/goto-gcc/linker_script_start+size/main.c

@@ -1,9 +1,10 @@
-CORE
+CORE gnu-ld-only
 main.c
--o out.gb -T script.ld -nostdlib
+-o out.gb -T script.ld -nostdlib -static -Wall
 ^EXIT=0$
 ^SIGNAL=0$
 --
+Problem parsing linker script
 ^warning: ignoring
 ^CONVERSION ERROR$
 --

…nsi-c/linker_script_start+size/script.ld …o-gcc/linker_script_start+size/script.ldregression/ansi-c/linker_script_start+size/script.ld renamed to regression/goto-gcc/linker_script_start+size/script.ld regression/ansi-c/linker_script_start+size/script.ld renamed to regression/goto-gcc/linker_script_start+size/script.ld

@@ -1,6 +1,7 @@
 extern char sym[];
 
-int main(){
+int main()
+{
   int foo = (int)sym;
   return 0;
 }