Avoid unnecessary copies in report_util.cpp

hannes-steffenhagen-diffblue · hannes-steffenhagen-diffblue · commit 13e31f5ab119 · 2020-06-29T17:57:32.000+01:00
Without the &amp; here we copy the items we loop over, which is unnecessary in these
cases.
diff --git a/src/goto-checker/report_util.cpp b/src/goto-checker/report_util.cpp
@@ -473,7 +473,7 @@ static void output_fault_localization_plain(
   messaget &log)
 {
   log.result() << "\n** Most likely fault location:" << messaget::eom;
-  for(const auto fault_location_pair : fault_locations)
+  for(const auto &fault_location_pair : fault_locations)
   {
     output_fault_localization_plain(
       fault_location_pair.first, fault_location_pair.second, log);
@@ -509,7 +509,7 @@ static void output_fault_localization_xml(
   messaget &log)
 {
   xmlt dest("fault-localization");
-  for(const auto fault_location_pair : fault_locations)
+  for(const auto &fault_location_pair : fault_locations)
   {
     xmlt xml_diagnosis =
       xml(fault_location_pair.first, fault_location_pair.second, log);

Original file line number	Diff line number	Diff line change
`@@ -473,7 +473,7 @@ static void output_fault_localization_plain(`
`473`	`473`	`messaget &log)`
`474`	`474`	`{`
`475`	`475`	`log.result() << "\n** Most likely fault location:" << messaget::eom;`
`476`		`- for(const auto fault_location_pair : fault_locations)`
	`476`	`+ for(const auto &fault_location_pair : fault_locations)`
`477`	`477`	`{`
`478`	`478`	`output_fault_localization_plain(`
`479`	`479`	`fault_location_pair.first, fault_location_pair.second, log);`
`@@ -509,7 +509,7 @@ static void output_fault_localization_xml(`
`509`	`509`	`messaget &log)`
`510`	`510`	`{`
`511`	`511`	`xmlt dest("fault-localization");`
`512`		`- for(const auto fault_location_pair : fault_locations)`
	`512`	`+ for(const auto &fault_location_pair : fault_locations)`
`513`	`513`	`{`
`514`	`514`	`xmlt xml_diagnosis =`
`515`	`515`	`xml(fault_location_pair.first, fault_location_pair.second, log);`