fix: replace standalone indicators custom forms [DHIS2-21607]#563
Open
tomzemp wants to merge 2 commits into
Open
fix: replace standalone indicators custom forms [DHIS2-21607]#563tomzemp wants to merge 2 commits into
tomzemp wants to merge 2 commits into
Conversation
|
Contributor
|
🚀 Deployed on https://pr-563--dhis2-data-entry.netlify.app |
tomzemp
commented
Jun 8, 2026
| export const CustomFormTotalCell = ({ dataElementId }) => { | ||
| const dataValues = useValueStore((state) => state.getDataValues()) | ||
| const dataElementValues = dataValues?.[dataElementId] || {} | ||
| const dataElementValues = useMemo( |
Member
Author
There was a problem hiding this comment.
this is not related, but is in the same directory, and the linter pointed this error out to me (this just guarantees the object reference is stable, but if it's defined, it wouldn't be an issue)
Sharmyn28
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #471
We had logic for custom forms that replaced indicator cells if (and only if) they were inside
<td>elements.This PR updates the logic to replace standalone indicator cells as well.