Skip to content

Commit 673f110

Browse files
committed
Review comments
1 parent b905a82 commit 673f110

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

dfetch/manifest/project.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@
278278

279279
from dfetch.manifest.remote import Remote
280280
from dfetch.manifest.version import Version
281-
from dfetch.util.util import always_str_list
281+
from dfetch.util.util import always_str_list, str_if_possible
282282

283283
ProjectEntryDict = TypedDict(
284284
"ProjectEntryDict",
@@ -468,7 +468,7 @@ def as_yaml(self) -> dict[str, Union[str, list[str]]]:
468468
"src": self._src,
469469
"dst": self._dst if self._dst != self._name else None,
470470
"url": self._url,
471-
"patch": self._patch,
471+
"patch": str_if_possible(self._patch),
472472
"branch": self._branch,
473473
"tag": self._tag,
474474
"repo-path": self._repo_path,

dfetch/project/subproject.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ def update(
132132
for patch in self.__project.patch:
133133
if os.path.exists(patch):
134134
self.apply_patch(patch)
135-
applied_patches += [patch]
135+
applied_patches.append(patch)
136136
else:
137137
logger.warning(f"Skipping non-existent patch {patch}")
138138

0 commit comments

Comments
 (0)