Harden WNN DSM enforcement#25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
WnnTelemetrywith defaults and atimestamp_ms, adding an upper oscillatory-prefactor guard (WNN_MAX_OSCILLATORY_PREFACTOR), and rejecting non-finite or negative telemetry values.last_estimated_Rmax_, and made DSM fail closed when curvature estimates are non-finite.ITLManagerlifecycle (payload sizing, entry hashing, flash-backedcommit, Merkle batching viaprocess_merkle_batch,flush_pending) and changedlog_wnn_rollback_eventto return success/failure of ledger commits.execute_rollback_plannow rejects non-finite thrust/gimbal values and negative thrust, andtrigger_wnn_immediate_rollbackvalidatesrollback_countbounds androllback_storebefore indexing and emits metrics when rollbacks are rejected or executed.tests/sil/test_dsm_wnn.cppcovering nominal WNN behavior, boundary-triggered rollback, invalid telemetry fail-closed behavior, and reversed-dilation shutdown; expandedtests/sil/test_rollback_execution.cppto cover non-finite thrust and out-of-range rollback count; updatedtests/sil/CMakeLists.txtto add the new test target.Testing
cmake -S tests/sil -B build/silandcmake --build build/sil -j2which produced the test executables.ctest --test-dir build/sil --output-on-failureand observed all tests pass.Codex Task