Core: updatating async-http-client instead of foundation urlsession

Author: asielcabrera

Package.resolved

@@ -16,7 +16,8 @@ let package = Package(
         .library(name: "Github", targets: ["Github"])
     ],
     dependencies: [
-        .package(url: "https://github.com/apple/swift-http-types", .upToNextMajor(from: "0.1.1"))
+        .package(url: "https://github.com/apple/swift-http-types", .upToNextMajor(from: "0.1.1")),
+        .package(url: "https://github.com/swift-server/async-http-client.git", from: "1.9.0")
     ],
     targets: [
 
@@ -42,6 +43,7 @@ let package = Package(
             dependencies: [
                 .product(name: "HTTPTypes", package: "swift-http-types"),
                 .product(name: "HTTPTypesFoundation", package: "swift-http-types"),
+                .product(name: "AsyncHTTPClient", package: "async-http-client"),
             ]
         ),
         .testTarget(

Package.swift

@@ -6,9 +6,6 @@
 //
 
 import Foundation
-#if canImport(FoundationNetworking)
-import FoundationNetworking
-#endif
 import HttpClient
 import HTTPTypes
 
@@ -53,7 +50,7 @@ extension GitHub {
 
     let request = HTTPRequest(method: method, url: endpoint, queries: queries, headers: headers)
 
-    let (data, _) = try await session.data(for: request)
+    let (data, _) = try await execute( request)
 
     let notifications = try decode([Notification].self, from: data)
 

Sources/Github/GitHubAPI/Activity/Notifications/Notifications.swift

@@ -6,9 +6,6 @@
 //
 
 import Foundation
-#if canImport(FoundationNetworking)
-import FoundationNetworking
-#endif
 import HttpClient
 import HTTPTypes
 
@@ -38,7 +35,7 @@ extension GitHub {
 
     let request = HTTPRequest(method: method, url: endpoint, queries: queries, headers: headers)
 
-    let (data, _) = try await session.data(for: request)
+    let (data, _) = try await execute( request)
 
     let users = try decode([User].self, from: data)
 

Sources/Github/GitHubAPI/Activity/Starring/Stargazers.swift

@@ -6,9 +6,6 @@
 //
 
 import Foundation
-#if canImport(FoundationNetworking)
-import FoundationNetworking
-#endif
 import HttpClient
 import HTTPTypes
 
@@ -50,7 +47,7 @@ extension GitHub {
 
     let request = HTTPRequest(method: method, url: endpoint, queries: queries, headers: headers)
 
-    let (data, _) = try await session.data(for: request)
+    let (data, _) = try await execute( request)
 
     let collaborators = try decode([Collaborator].self, from: data)
 

Sources/Github/GitHubAPI/Collaborators/Collaborators.swift

@@ -6,9 +6,6 @@
 //
 
 import Foundation
-#if canImport(FoundationNetworking)
-import FoundationNetworking
-#endif
 import HttpClient
 import HTTPTypes
 
@@ -62,11 +59,11 @@ extension GitHub {
   }
   """
 
-    let httpRequest = HTTPRequest(method: method, url: endpoint, queries: [:], headers: headers)
-    var urlRequest = URLRequest(httpRequest: httpRequest)!
-    urlRequest.httpBody = try JSONEncoder().encode(["query": query])
+    let request = HTTPRequest(method: method, url: endpoint, queries: [:], headers: headers)
 
-    let (data, _) = try await session.data(for: urlRequest)
+    let bodyData = try JSONEncoder().encode(["query": query])
+    
+    let (data, _) = try await execute(request, body: bodyData)
     let response = try decode(DiscussionResponse.self, from: data)
 
     return response.discussion

Sources/Github/GitHubAPI/Discussions/DiscussionRequest.swift

@@ -6,9 +6,6 @@
 //
 
 import Foundation
-#if canImport(FoundationNetworking)
-import FoundationNetworking
-#endif
 import HttpClient
 import HTTPTypes
 
@@ -73,11 +70,10 @@ extension GitHub {
   }
   """
 
-    let httpRequest = HTTPRequest(method: method, url: endpoint, queries: [:], headers: headers)
-    var urlRequest = URLRequest(httpRequest: httpRequest)!
-    urlRequest.httpBody = try JSONEncoder().encode(["query": query])
-    
-    let (data, _) = try await session.data(for: urlRequest)
+    let request = HTTPRequest(method: method, url: endpoint, queries: [:], headers: headers)
+    let body = try JSONEncoder().encode(["query": query])
+
+    let (data, _) = try await execute(request, body: body)
     let response = try decode(DiscussionsResponse.self, from: data)
 
     return response.discussions

Sources/Github/GitHubAPI/Discussions/Discussions.swift

@@ -6,9 +6,6 @@
 //
 
 import Foundation
-#if canImport(FoundationNetworking)
-import FoundationNetworking
-#endif
 import HttpClient
 import HTTPTypes
 
@@ -24,7 +21,7 @@ extension GitHub {
 
     let request = HTTPRequest(method: method, url: endpoint, queries: [:], headers: headers)
 
-    let (data, _) = try await session.data(for: request)
+    let (data, _) = try await execute( request)
 
     let templates = try decode([String].self, from: data)
 

Sources/Github/GitHubAPI/Gitignore/AllGitignoreTemplateNames.swift

@@ -6,9 +6,6 @@
 //
 
 import Foundation
-#if canImport(FoundationNetworking)
-import FoundationNetworking
-#endif
 import HttpClient
 import HTTPTypes
 
@@ -26,7 +23,7 @@ extension GitHub {
 
     let request = HTTPRequest(method: method, url: endpoint, queries: [:], headers: headers)
 
-    let (data, _) = try await session.data(for: request)
+    let (data, _) = try await execute( request)
 
     let template = try decode(GitignoreTemplate.self, from: data)
 

Sources/Github/GitHubAPI/Gitignore/GetGitignoreTemplate.swift

@@ -6,9 +6,6 @@
 //
 
 import Foundation
-#if canImport(FoundationNetworking)
-import FoundationNetworking
-#endif
 import HttpClient
 import HTTPTypes
 
@@ -48,7 +45,7 @@ extension GitHub {
 
     let request = HTTPRequest(method: method, url: endpoint, queries: queries, headers: headers)
 
-    let (data, _) = try await session.data(for: request)
+    let (data, _) = try await execute( request)
 
     let comments = try decode([Comment].self, from: data)