From 3b0456b868d5a44cc4e4aa89df4f73db0507b4e2 Mon Sep 17 00:00:00 2001 From: ayman abdelghany Date: Tue, 3 May 2016 01:11:01 +0200 Subject: [PATCH] Literal boolean values should not be used in condition expressions --- .../pathfinder/reference/HtmlRenderFarm.java | 2 +- .../pathfinder/reference/SearchProvider.java | 2 +- .../api/AbstractContentProvider.java | 2 +- .../pathfinder/reference/db/BaseDbHelper.java | 2 +- .../pathfinder/reference/db/DbWrangler.java | 2 +- .../preference/FilterPreferenceManager.java | 36 +++++++++---------- .../reference/render/html/HtmlRenderer.java | 2 +- 7 files changed, 24 insertions(+), 24 deletions(-) diff --git a/app/src/main/java/org/evilsoft/pathfinder/reference/HtmlRenderFarm.java b/app/src/main/java/org/evilsoft/pathfinder/reference/HtmlRenderFarm.java index bea0069..e53f357 100644 --- a/app/src/main/java/org/evilsoft/pathfinder/reference/HtmlRenderFarm.java +++ b/app/src/main/java/org/evilsoft/pathfinder/reference/HtmlRenderFarm.java @@ -212,7 +212,7 @@ public boolean suppressTitle() { return true; } HtmlRenderer prev = renderPath.get(renderPath.size() - 1); - return prev.suppressNextTitle == true; + return prev.suppressNextTitle; } public String renderFooter() { diff --git a/app/src/main/java/org/evilsoft/pathfinder/reference/SearchProvider.java b/app/src/main/java/org/evilsoft/pathfinder/reference/SearchProvider.java index ab25df8..7c16c0c 100644 --- a/app/src/main/java/org/evilsoft/pathfinder/reference/SearchProvider.java +++ b/app/src/main/java/org/evilsoft/pathfinder/reference/SearchProvider.java @@ -19,7 +19,7 @@ public boolean onCreate() { } public boolean initializeDatabase() { - if (dbWrangler != null && dbWrangler.isClosed() == false) { + if (dbWrangler != null && !dbWrangler.isClosed()) { return true; } boolean cont = true; diff --git a/app/src/main/java/org/evilsoft/pathfinder/reference/api/AbstractContentProvider.java b/app/src/main/java/org/evilsoft/pathfinder/reference/api/AbstractContentProvider.java index e10d070..bc43f91 100644 --- a/app/src/main/java/org/evilsoft/pathfinder/reference/api/AbstractContentProvider.java +++ b/app/src/main/java/org/evilsoft/pathfinder/reference/api/AbstractContentProvider.java @@ -45,7 +45,7 @@ public boolean onCreate() { } public boolean initializeDatabase() { - if (dbWrangler != null && dbWrangler.isClosed() == false) { + if (dbWrangler != null && !dbWrangler.isClosed()) { return true; } boolean cont = true; diff --git a/app/src/main/java/org/evilsoft/pathfinder/reference/db/BaseDbHelper.java b/app/src/main/java/org/evilsoft/pathfinder/reference/db/BaseDbHelper.java index dc03db4..f23a845 100644 --- a/app/src/main/java/org/evilsoft/pathfinder/reference/db/BaseDbHelper.java +++ b/app/src/main/java/org/evilsoft/pathfinder/reference/db/BaseDbHelper.java @@ -75,7 +75,7 @@ private void buildDatabase(boolean retry) throws IOException, } if (retry) { boolean dbExists = checkDatabase(); - if (dbExists == false) { + if (!dbExists) { buildDatabase(false); } } diff --git a/app/src/main/java/org/evilsoft/pathfinder/reference/db/DbWrangler.java b/app/src/main/java/org/evilsoft/pathfinder/reference/db/DbWrangler.java index 20843c3..7f522ed 100644 --- a/app/src/main/java/org/evilsoft/pathfinder/reference/db/DbWrangler.java +++ b/app/src/main/java/org/evilsoft/pathfinder/reference/db/DbWrangler.java @@ -53,7 +53,7 @@ public void checkDatabases() throws IOException, LimitedSpaceException { } checkIndexDb(current); checkBookDbs(current); - if (current == false) { + if (!current) { SharedPreferences.Editor editor = settings.edit(); editor.putInt(CURRENT_VERSION, VERSION); editor.commit(); diff --git a/app/src/main/java/org/evilsoft/pathfinder/reference/preference/FilterPreferenceManager.java b/app/src/main/java/org/evilsoft/pathfinder/reference/preference/FilterPreferenceManager.java index 26473d6..e8104f8 100644 --- a/app/src/main/java/org/evilsoft/pathfinder/reference/preference/FilterPreferenceManager.java +++ b/app/src/main/java/org/evilsoft/pathfinder/reference/preference/FilterPreferenceManager.java @@ -28,58 +28,58 @@ public static String getSourceFilter(Context context, List args, SharedPreferences preferences = PreferenceManager .getDefaultSharedPreferences(context); - if (preferences.getBoolean("source_APG", true) == false) { + if (!preferences.getBoolean("source_APG", true)) { sourceList.add("Advanced Player's Guide"); } - if (preferences.getBoolean("source_ACG", true) == false) { + if (!preferences.getBoolean("source_ACG", true)) { sourceList.add("Advanced Class Guide"); } - if (preferences.getBoolean("source_ARG", true) == false) { + if (!preferences.getBoolean("source_ARG", true)) { sourceList.add("Advanced Race Guide"); } - if (preferences.getBoolean("source_UCA", true) == false) { + if (!preferences.getBoolean("source_UCA", true)) { sourceList.add("Ultimate Campaign"); } - if (preferences.getBoolean("source_UC", true) == false) { + if (!preferences.getBoolean("source_UC", true)) { sourceList.add("Ultimate Combat"); } - if (preferences.getBoolean("source_UE", true) == false) { + if (!preferences.getBoolean("source_UE", true)) { sourceList.add("Ultimate Equipment"); } - if (preferences.getBoolean("source_UM", true) == false) { + if (!preferences.getBoolean("source_UM", true)) { sourceList.add("Ultimate Magic"); } - if (preferences.getBoolean("source_MA", true) == false) { + if (!preferences.getBoolean("source_MA", true)) { sourceList.add("Mythic Adventures"); } - if (preferences.getBoolean("source_OA", true) == false) { + if (!preferences.getBoolean("source_OA", true)) { sourceList.add("Occult Adventures"); } - if (preferences.getBoolean("source_TG", true) == false) { + if (!preferences.getBoolean("source_TG", true)) { sourceList.add("Technology Guide"); } - if (preferences.getBoolean("source_B1", true) == false) { + if (!preferences.getBoolean("source_B1", true)) { sourceList.add("Bestiary"); } - if (preferences.getBoolean("source_B2", true) == false) { + if (!preferences.getBoolean("source_B2", true)) { sourceList.add("Bestiary 2"); } - if (preferences.getBoolean("source_B3", true) == false) { + if (!preferences.getBoolean("source_B3", true)) { sourceList.add("Bestiary 3"); } - if (preferences.getBoolean("source_B4", true) == false) { + if (!preferences.getBoolean("source_B4", true)) { sourceList.add("Bestiary 4"); } - if (preferences.getBoolean("source_GMG", true) == false) { + if (!preferences.getBoolean("source_GMG", true)) { sourceList.add("Game Mastery Guide"); } - if (preferences.getBoolean("source_PFU", true) == false) { + if (!preferences.getBoolean("source_PFU", true)) { sourceList.add("Pathfinder Unchained"); } - if (preferences.getBoolean("source_NPC", true) == false) { + if (!preferences.getBoolean("source_NPC", true)) { sourceList.add("NPC Codex"); } - if (preferences.getBoolean("source_MC", true) == false) { + if (!preferences.getBoolean("source_MC", true)) { sourceList.add("Monster Codex"); } if (sourceList.size() > 0) { diff --git a/app/src/main/java/org/evilsoft/pathfinder/reference/render/html/HtmlRenderer.java b/app/src/main/java/org/evilsoft/pathfinder/reference/render/html/HtmlRenderer.java index 623e8ba..7ab1e77 100644 --- a/app/src/main/java/org/evilsoft/pathfinder/reference/render/html/HtmlRenderer.java +++ b/app/src/main/java/org/evilsoft/pathfinder/reference/render/html/HtmlRenderer.java @@ -53,7 +53,7 @@ public String render(Cursor cursor, String newUri, int depth, boolean top, this.alt = FullSectionAdapter.SectionUtils.getAlt(cursor); localSetValues(); StringBuffer sb = new StringBuffer(); - if (suppressTitle == false) { + if (!suppressTitle) { sb.append(renderTitle()); } sb.append(renderImage());