From d945e9a00ff8a4b55a2b216b9372e664021b4309 Mon Sep 17 00:00:00 2001 From: KarimALotfy Date: Fri, 24 Apr 2026 18:02:06 +0200 Subject: [PATCH 1/7] #1456: update uninstall command Changed the uninstall command to run from the correct directory ([%IDE_ROOT]\_ide\installation) and added proper logging. Also set IDE_ROOT environment variable to be removed on uninstall. --- windows-installer/Package.wxs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/windows-installer/Package.wxs b/windows-installer/Package.wxs index de44aef08e..63fb227538 100644 --- a/windows-installer/Package.wxs +++ b/windows-installer/Package.wxs @@ -12,7 +12,7 @@ - + @@ -51,7 +51,7 @@ From 842678915ee7488cda6451888119210be26bf1f2 Mon Sep 17 00:00:00 2001 From: KarimALotfy Date: Mon, 27 Apr 2026 16:00:22 +0200 Subject: [PATCH 2/7] fix: update uninstall command to use INSTALLFOLDER variable --- windows-installer/Package.wxs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/windows-installer/Package.wxs b/windows-installer/Package.wxs index 63fb227538..14d72a7d37 100644 --- a/windows-installer/Package.wxs +++ b/windows-installer/Package.wxs @@ -51,7 +51,7 @@ From 60b075f88a63b81130ea6c0e05459b485a8b8646 Mon Sep 17 00:00:00 2001 From: KarimALotfy Date: Mon, 27 Apr 2026 16:06:27 +0200 Subject: [PATCH 3/7] #1456: create test MSI identity for uninstall verification --- windows-installer/Package.wxs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/windows-installer/Package.wxs b/windows-installer/Package.wxs index 14d72a7d37..d4d60c74d1 100644 --- a/windows-installer/Package.wxs +++ b/windows-installer/Package.wxs @@ -1,7 +1,7 @@ - + - + From 6d9673ebc5f0a6e5f31f71ff0b87cc9a7179e21e Mon Sep 17 00:00:00 2001 From: KarimALotfy Date: Mon, 27 Apr 2026 16:42:57 +0200 Subject: [PATCH 4/7] #1456: create test MSI identity with a modified guiid code --- windows-installer/Package.wxs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/windows-installer/Package.wxs b/windows-installer/Package.wxs index d4d60c74d1..0bd0cc5e9d 100644 --- a/windows-installer/Package.wxs +++ b/windows-installer/Package.wxs @@ -1,7 +1,7 @@  - + From 49e8c4cb39604f1e509e750741bc57e50d5b8a51 Mon Sep 17 00:00:00 2001 From: KarimALotfy Date: Mon, 27 Apr 2026 20:35:09 +0200 Subject: [PATCH 5/7] #1456:revert change of code and name --- windows-installer/Package.wxs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/windows-installer/Package.wxs b/windows-installer/Package.wxs index 0bd0cc5e9d..6421f02c69 100644 --- a/windows-installer/Package.wxs +++ b/windows-installer/Package.wxs @@ -1,7 +1,7 @@ - + - + From d7820b167b5800bcf3b6ac091df9326df03bae81 Mon Sep 17 00:00:00 2001 From: KarimALotfy Date: Mon, 27 Apr 2026 20:51:22 +0200 Subject: [PATCH 6/7] #1456: refactor uninstall process on Windows by checking for bash availability --- .../java/com/devonfw/tools/ide/tool/IdeasyCommandlet.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/cli/src/main/java/com/devonfw/tools/ide/tool/IdeasyCommandlet.java b/cli/src/main/java/com/devonfw/tools/ide/tool/IdeasyCommandlet.java index 2405ad193b..c4a3788199 100644 --- a/cli/src/main/java/com/devonfw/tools/ide/tool/IdeasyCommandlet.java +++ b/cli/src/main/java/com/devonfw/tools/ide/tool/IdeasyCommandlet.java @@ -615,7 +615,13 @@ private void deleteDownloadCache() { private void uninstallIdeasyIdePath(Path idePath) { if (this.context.getSystemInfo().isWindows()) { - this.context.newProcess().executable("bash").addArgs("-c", + Path bash = this.context.findBash(); + if (bash == null) { + LOG.warn("Could not find bash for asynchronous deletion of {}. Falling back to direct deletion.", idePath); + this.context.getFileAccess().delete(idePath); + return; + } + this.context.newProcess().executable(bash).addArgs("-c", "sleep 10 && rm -rf \"" + WindowsPathSyntax.MSYS.format(idePath) + "\"").run(ProcessMode.BACKGROUND); IdeLogLevel.INTERACTION.log(LOG, "To prevent windows file locking errors, we perform an asynchronous deletion of {} in background now.\n" From 490a9742254604e08d6402deeef2b409ebefb30c Mon Sep 17 00:00:00 2001 From: KarimALotfy Date: Tue, 28 Apr 2026 10:19:43 +0200 Subject: [PATCH 7/7] #1456: revert change of ProductName --- windows-installer/Package.wxs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/windows-installer/Package.wxs b/windows-installer/Package.wxs index 6421f02c69..14d72a7d37 100644 --- a/windows-installer/Package.wxs +++ b/windows-installer/Package.wxs @@ -1,4 +1,4 @@ - +