Skip to content

Implement proper ZIP extraction #1884

@hohwille

Description

@hohwille

Task summary

In #1875 we discovered that ZIP files can also contain links.
It was really hard to figure out how to preserve file permissions when extracting ZIP archives in Java but we managed to solve this.

This story has the goal to support links for ZIP extraction in pure Java.
PR #1875 is considered as a quickfix or workaround on MacOS that can be reverted when this is fixed.

The same bug still exists on Linux and relying on unzip executable to be installed on any Linux system seems fragile since this is simply not always given.
According to the valley of tears we already have gone through with ZIP extraction in Java, I guess that fixing this will not be a very easy task. I hope you can prove me wrong...

Additional context

Unpacking a ZIP or TAR archive should be easy right? You use a library and write 3 lines of code to extract the archive.
The truth is however totally different.

See also:

And by the way, creating a (symbolic) link in Java working cross-platform (including Windows) also is easy right?
Nope. Also here we spent a lot of sweat and tears to get it right. So even with Java cross-platform support can be a big challenge.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestready-to-implementunpacklogic to unpack archives (tar, zip, tgz, zbz2, msi, dmg, etc.)

    Type

    Projects

    Status

    🆕 New

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions