Skip to content

Commit f632582

Browse files
committed
Fix tag separator and group config polling
1 parent 5c06832 commit f632582

2 files changed

Lines changed: 10 additions & 5 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1212
- **Node Disk SMART Information**: Node details now display disk health status and SMART data for all attached disks, including disk type (SSD/HDD), size, model, and health status (PASSED/FAILED).
1313
- **System Update Notifications**: Node details now show available system package updates with version information, displaying up to 5 pending updates with a count of any additional updates.
1414
- **Icon Toggle**: Added multiple ways to control icons/emojis throughout the UI. Icons are enabled by default. To disable: use `--show-icons=false` CLI flag, `PVETUI_SHOW_ICONS=false` environment variable, or `show_icons: false` in YAML config. (#75)
15-
- **Guest Tags**: Added editable tag list for VM/LXC configuration, using a comma-separated tag field in the Edit Configuration form. (#76)
15+
- **Guest Tags**: Added editable tag list for VM/LXC configuration, using a semicolon-separated tag field in the Edit Configuration form. (#76)
1616
- **SSH Jump Host Support**: Added SSH jump host (bastion host) configuration for accessing Proxmox environments through an intermediate SSH server. Configure via config wizard, CLI flags (`--ssh-jumphost-addr`, `--ssh-jumphost-user`, `--ssh-jumphost-keyfile`, `--ssh-jumphost-port`), environment variables (`PVETUI_SSH_JUMPHOST_ADDR`, `PVETUI_SSH_JUMPHOST_USER`, `PVETUI_SSH_JUMPHOST_KEYFILE`, `PVETUI_SSH_JUMPHOST_PORT`), or YAML config (`ssh_jump_host` section). Per-profile configuration supported.
1717
- **Release Announcements**: GoReleaser now posts release announcements to Mastodon and Bluesky when the required secrets are configured.
1818

internal/ui/components/vm_config.go

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,8 @@ func NewVMConfigPage(app *App, vm *api.VM, config *api.VMConfig, saveFn func(*ap
118118
})
119119

120120
// Tags
121-
initialTags := strings.TrimSpace(config.Tags)
122-
form.AddInputField("Tags (comma-separated)", initialTags, 40, nil, func(text string) {
121+
initialTags := normalizeTags(config.Tags)
122+
form.AddInputField("Tags (semicolon-separated)", initialTags, 40, nil, func(text string) {
123123
page.config.Tags = normalizeTags(text)
124124
page.config.TagsExplicit = true
125125
})
@@ -302,7 +302,7 @@ func normalizeTags(raw string) string {
302302
}
303303
cleaned = append(cleaned, trimmed)
304304
}
305-
return strings.Join(cleaned, ",")
305+
return strings.Join(cleaned, ";")
306306
}
307307

308308
// showResizeStorageModal displays a modal for resizing a storage volume.
@@ -429,13 +429,18 @@ func showResizeStorageModal(app *App, vm *api.VM) {
429429
// to both the config endpoint and the cluster resources endpoint before refreshing the UI.
430430
// This prevents race conditions where config is updated but cluster resources still show old names.
431431
func (app *App) pollForConfigChange(vm *api.VM, expectedName string) {
432+
client, err := app.getClientForVM(vm)
433+
if err != nil {
434+
client = app.client
435+
}
436+
432437
// Poll every 500ms for up to 15 seconds (increased timeout for cluster resources propagation)
433438
maxAttempts := 30
434439
for attempt := 0; attempt < maxAttempts; attempt++ {
435440
time.Sleep(500 * time.Millisecond)
436441

437442
// First check if the config endpoint has the new name using the existing API function
438-
config, err := app.client.GetVMConfig(vm)
443+
config, err := client.GetVMConfig(vm)
439444
configUpdated := false
440445

441446
if err == nil && config != nil {

0 commit comments

Comments
 (0)