test(plugin-code-server): fix windows child_process spawning and cleanup

Author: antfubot

plugins/code-server/src/node/detect.ts

@@ -1,5 +1,6 @@
 import type { Buffer } from 'node:buffer'
 import { spawn } from 'node:child_process'
+import process from 'node:process'
 
 export interface DetectCodeServerResult {
   installed: boolean
@@ -30,7 +31,11 @@ export function detectCodeServer(bin = 'code-server', timeoutMs = 5000): Promise
 
     let child
     try {
-      child = spawn(bin, ['--version'], { windowsHide: true, stdio: ['ignore', 'pipe', 'ignore'] })
+      child = spawn(bin, ['--version'], {
+        windowsHide: true,
+        stdio: ['ignore', 'pipe', 'ignore'],
+        shell: process.platform === 'win32' && bin.endsWith('.cmd'),
+      })
     }
     catch {
       finish({ installed: false, bin })

plugins/code-server/src/node/supervisor.ts

@@ -12,7 +12,7 @@ import type {
   CodeServerStartResult,
   CodeServerStatusResult,
 } from '../types'
-import { spawn } from 'node:child_process'
+import { execSync, spawn } from 'node:child_process'
 import { createHash, randomBytes } from 'node:crypto'
 import { request as httpRequest } from 'node:http'
 import process from 'node:process'
@@ -153,6 +153,7 @@ export class CodeServerSupervisor {
         env,
         windowsHide: true,
         stdio: ['ignore', 'pipe', 'pipe'],
+        shell: process.platform === 'win32' && this.bin.endsWith('.cmd'),
       })
     }
     catch (error) {
@@ -240,7 +241,12 @@ export class CodeServerSupervisor {
 
   private terminate(child: ChildProcess): void {
     try {
-      child.kill('SIGTERM')
+      if (process.platform === 'win32' && this.bin.endsWith('.cmd') && child.pid) {
+        execSync(`taskkill /pid ${child.pid} /t /f`, { stdio: 'ignore' })
+      }
+      else {
+        child.kill('SIGTERM')
+      }
     }
     catch {
       // Already gone.

plugins/code-server/test/_utils.ts

@@ -59,5 +59,12 @@ process.on('SIGINT', () => process.exit(0))
 `
   writeFileSync(binPath, script)
   chmodSync(binPath, 0o755)
+
+  if (process.platform === 'win32') {
+    const cmdPath = `${binPath}.cmd`
+    writeFileSync(cmdPath, `@node "${binPath}" %*`)
+    return cmdPath
+  }
+
   return binPath
 }