fix(plugin-terminals): make PTY tests Windows-safe and harness leak-free

- Gate the PTY-semantics tests (stdin echo, SIGWINCH resize, foreground
  process name) to POSIX; Windows keeps the isTTY interactive coverage.
  These rely on behaviours conpty doesn't provide (no SIGWINCH; `.process`
  returns the TERM name).
- Ignore the Windows `xterm-256color` TERM-name fallback so it never
  surfaces as a session label.
- Dispose the terminal manager on test server close so spawned PTY/piped
  child processes don't leak across runs.

Author: antfubot

plugins/terminals/src/node/backend.ts

@@ -55,6 +55,9 @@ interface PtyProcess {
   kill: (signal?: string) => void
 }
 
+/** TERM name handed to the PTY; also used to reject the Windows fallback. */
+const PTY_TERM_NAME = 'xterm-256color'
+
 let ptyModulePromise: Promise<PtyModule | undefined> | undefined
 
 /**
@@ -90,7 +93,7 @@ export async function spawnPty(options: SpawnBackendOptions): Promise<TerminalPr
   let proc: PtyProcess
   try {
     proc = pty.spawn(options.command, options.args, {
-      name: 'xterm-256color',
+      name: PTY_TERM_NAME,
       cols: options.cols,
       rows: options.rows,
       cwd: options.cwd,
@@ -136,7 +139,10 @@ export async function spawnPty(options: SpawnBackendOptions): Promise<TerminalPr
     onExit: cb => proc.onExit(e => cb(e.exitCode ?? 0)),
     getProcessName: () => {
       try {
-        return proc.process || undefined
+        const name = proc.process
+        // On Windows node-pty falls back to the TERM name rather than the
+        // foreground process — don't surface that as a session label.
+        return name && name !== PTY_TERM_NAME ? name : undefined
       }
       catch {
         return undefined

plugins/terminals/test/_utils.ts

@@ -13,6 +13,7 @@ import { createWsRpcChannel } from 'devframe/rpc/transports/ws-client'
 import { getPort } from 'get-port-please'
 import { H3 } from 'h3'
 import { createTerminalsDevframe } from '../src/index'
+import { getTerminalManager } from '../src/node/index'
 
 export type TerminalsServer = StartedServer & {
   ctx: DevframeNodeContext
@@ -40,6 +41,20 @@ export async function startTerminalsServer(options: TerminalsOptions = {}): Prom
   await definition.setup(ctx)
 
   const server = await startHttpAndWs({ context: ctx, host, port, app, auth: false })
+
+  // Tear down spawned terminal processes (PTYs / piped children) alongside
+  // the HTTP+WS server so tests don't leak `node`/shell processes.
+  const closeServer = server.close.bind(server)
+  server.close = async () => {
+    try {
+      getTerminalManager(ctx).dispose()
+    }
+    catch {
+      // Manager may not be initialised if setup failed.
+    }
+    await closeServer()
+  }
+
   return Object.assign(server, { ctx, port })
 }
 

plugins/terminals/test/terminals.test.ts

@@ -9,6 +9,11 @@ import { bootClient, call, collectUntil, startTerminalsServer } from './_utils'
 vi.stubGlobal('WebSocket', WebSocket)
 
 const NODE = process.execPath
+// PTY semantics differ on Windows (conpty): no SIGWINCH, the foreground
+// process name resolves to the TERM name, and stdin round-trips are slow to
+// render. These behaviours are exercised on POSIX; Windows keeps the
+// `isTTY` interactive coverage below.
+const itPosix = process.platform === 'win32' ? it.skip : it
 
 function subscribe(client: TestClient, id: string) {
   return client.streaming.subscribe<string>(TERMINAL_STREAM_CHANNEL, id)
@@ -66,7 +71,7 @@ describe('@devframes/plugin-terminals', () => {
     ).rejects.toThrow(/read-only/i)
   })
 
-  it('runs an interactive PTY session that accepts input', async () => {
+  itPosix('runs an interactive PTY session that accepts input', async () => {
     const client = bootClient(server.port)
     await new Promise(r => setTimeout(r, 50))
 
@@ -100,7 +105,7 @@ describe('@devframes/plugin-terminals', () => {
     expect(output).toContain('isTTY=true')
   })
 
-  it('propagates resize to the PTY (SIGWINCH) for TUI layout', async () => {
+  itPosix('propagates resize to the PTY (SIGWINCH) for TUI layout', async () => {
     const client = bootClient(server.port)
     await new Promise(r => setTimeout(r, 50))
 
@@ -135,7 +140,7 @@ describe('@devframes/plugin-terminals', () => {
     expect(restarted.status).toBe('running')
   })
 
-  it('tracks the foreground process name for PTY sessions', async () => {
+  itPosix('tracks the foreground process name for PTY sessions', async () => {
     const client = bootClient(server.port)
     await new Promise(r => setTimeout(r, 50))