fix: enforce typecheck across the monorepo

antfubot · antfubot · commit 4f9ecbab1f85 · 2026-06-19T02:44:43.000Z
The root `tsc -b` was a no-op — `tsconfig.json` had `files: []` and no
project references, so `pnpm typecheck` passed without checking any
package and CI never caught type regressions (~20 had accumulated).

Wire `pnpm typecheck` to `turbo run typecheck`, giving each package its
own `tsc --noEmit` script and an explicit `include`. Cross-package
imports resolve to source via the existing `paths` aliases, so checks
need no prior build. `plugins/*` is added to the workspace so future
plugins are typechecked automatically once they ship the script.

Fix the latent type errors this surfaces:
- declare the internal protocol RPC methods used by `broadcast`/`$call`
  (client-state sync, auth-revoke, anonymous-auth) and the hub's
  terminal/message notifications
- align `RpcSharedStateHost.get` with its string-keyed implementation,
  removing the casts it forced at every call site
- annotate deliberately-throwing dump test handlers so they don't infer
  a `never` return that broke `RpcDump` assignability
- supply the required `icon` on dock test entries and other minor fixes
diff --git a/AGENTS.md b/AGENTS.md
@@ -22,13 +22,15 @@ pnpm install      # requires pnpm@11.x
 pnpm build        # tsdown
 pnpm dev          # tsdown --watch
 pnpm test         # pnpm build && vitest (api snapshot guards against stale dist)
-pnpm typecheck    # tsc --noEmit
+pnpm typecheck    # turbo run typecheck (per-package tsc --noEmit)
 pnpm lint --fix   # ESLint via @antfu/eslint-config
 pnpm start        # tsx src/index.ts
 ```
 
 The `pnpm test` script intentionally runs `build` first so `tsnapi` snapshots compare against fresh `dist/`. `tsdown-stale-guard` enforces this in `test/api-snapshot.test.ts`.
 
+`pnpm typecheck` fans out through Turbo: every workspace package owns a `"typecheck": "tsc --noEmit"` script and its own `tsconfig.json` (extending `tsconfig.base.json` with an explicit `include`). Cross-package imports resolve to source through the `paths` aliases in `tsconfig.base.json`, so no prior build is needed. Any package added under `packages/*` or `plugins/*` is typechecked automatically once it ships that `typecheck` script — add one to every new package so it can't silently skip type errors.
+
 ## Conventions
 
 - RPC functions must use `defineRpcFunction`; always namespace IDs (`my-plugin:fn-name`).
diff --git a/package.json b/package.json
@@ -25,7 +25,7 @@
     "test:e2e:ui": "turbo run build && playwright test --ui",
     "test:ecosystem": "tsx scripts/ecosystem-ci.ts",
     "release": "bumpp -r",
-    "typecheck": "tsc -b",
+    "typecheck": "turbo run typecheck",
     "postinstall": "npx simple-git-hooks && skills-npm"
   },
   "devDependencies": {
diff --git a/packages/devframe/package.json b/packages/devframe/package.json
@@ -62,6 +62,7 @@
   "scripts": {
     "build": "tsdown",
     "watch": "tsdown --watch",
+    "typecheck": "tsc --noEmit",
     "prepack": "pnpm build && mkdir -p ./skills && cp -r ../../skills/devframe ./skills/devframe"
   },
   "peerDependencies": {
diff --git a/packages/devframe/src/adapters/mcp/__tests__/mcp-server.test.ts b/packages/devframe/src/adapters/mcp/__tests__/mcp-server.test.ts
@@ -149,7 +149,7 @@ describe('mcp adapter (in-memory)', () => {
   it('surfaces shared-state keys as MCP resources', async () => {
     const { ctx, client, cleanup } = await bootPair()
     try {
-      const state = await ctx.rpc.sharedState.get('my-plugin:counter' as any, {
+      const state = await ctx.rpc.sharedState.get('my-plugin:counter', {
         initialValue: { count: 7 },
       })
 
diff --git a/packages/devframe/src/adapters/mcp/build-server.ts b/packages/devframe/src/adapters/mcp/build-server.ts
@@ -226,7 +226,7 @@ function registerResourceHandlers(
     }
 
     if (parsed.kind === 'state') {
-      const state = await ctx.rpc.sharedState.get(parsed.key as any)
+      const state = await ctx.rpc.sharedState.get(parsed.key)
       return {
         contents: [
           {
diff --git a/packages/devframe/src/node/__tests__/host-functions.test.ts b/packages/devframe/src/node/__tests__/host-functions.test.ts
@@ -133,15 +133,15 @@ describe('rpcFunctionsHost', () => {
     it('should not throw in build mode', async () => {
       const host = new RpcFunctionsHost({ mode: 'build' } as DevframeNodeContext)
       await expect(host.broadcast({
-        method: 'devframe:terminals:updated',
+        method: 'devframe:auth:revoked',
         args: [],
       })).resolves.toBeUndefined()
     })
 
     it('should not throw in dev mode when rpc group is not yet set', async () => {
       const host = new RpcFunctionsHost({ mode: 'dev' } as DevframeNodeContext)
       await expect(host.broadcast({
-        method: 'devframe:terminals:updated',
+        method: 'devframe:auth:revoked',
         args: [],
       })).resolves.toBeUndefined()
     })
diff --git a/packages/devframe/src/node/host-diagnostics.ts b/packages/devframe/src/node/host-diagnostics.ts
@@ -14,7 +14,10 @@ export class DevframeDiagnosticsHost implements DevframeDiagnosticsHostType {
       ...opts,
       reporters: [devframeReporter, ...(opts.reporters ?? [])],
     } as Parameters<typeof defineDiagnostics>[0]
-    return defineDiagnostics(merged) as ReturnType<DevframeDiagnosticsHostType['defineDiagnostics']>
+    // Runtime passthrough: the per-call `Codes` generic can't be threaded
+    // through this assigned arrow, so the narrow return type is restored by
+    // the property's declared signature at every call site.
+    return defineDiagnostics(merged) as any
   }
 
   constructor(
diff --git a/packages/devframe/src/node/rpc-shared-state.ts b/packages/devframe/src/node/rpc-shared-state.ts
@@ -1,4 +1,4 @@
-import type { DevframeRpcSharedStates, RpcFunctionsHost, RpcSharedStateGetOptions, RpcSharedStateHost } from 'devframe/types'
+import type { RpcFunctionsHost, RpcSharedStateGetOptions, RpcSharedStateHost } from 'devframe/types'
 import type { SharedState, SharedStatePatch } from 'devframe/utils/shared-state'
 import { createSharedState } from 'devframe/utils/shared-state'
 import { createDebug } from 'obug'
@@ -97,7 +97,7 @@ export function createRpcSharedStateServerHost(
     handler: async (key: string) => {
       if (!sharedState.has(key))
         return undefined
-      const state = await host.get(key as keyof DevframeRpcSharedStates)
+      const state = await host.get(key)
       return state.value()
     },
     // Pre-compute snapshots for the build-mode static dump so the SPA
@@ -111,7 +111,7 @@ export function createRpcSharedStateServerHost(
     name: 'devframe:rpc:server-state:set',
     type: 'query',
     handler: async (key: string, value: any, syncId: string) => {
-      const state = await host.get(key as keyof DevframeRpcSharedStates, {
+      const state = await host.get(key, {
         initialValue: value,
       })
       state.mutate(() => value, syncId)
@@ -124,7 +124,7 @@ export function createRpcSharedStateServerHost(
     handler: async (key: string, patches: SharedStatePatch[], syncId: string) => {
       if (!sharedState.has(key))
         return
-      const state = await host.get(key as keyof DevframeRpcSharedStates)
+      const state = await host.get(key)
       state.patch(patches, syncId)
     },
   })
diff --git a/packages/devframe/src/rpc/dump/__tests__/dump.test.ts b/packages/devframe/src/rpc/dump/__tests__/dump.test.ts
@@ -118,7 +118,7 @@ describe('dumps', () => {
       dump: {
         inputs: [[]] as [][],
       },
-      handler: () => {
+      handler: (): void => {
         const err = new TypeError('boom', { cause: new Error('inner') }) as Error & { tags?: unknown }
         err.tags = tags
         throw err
@@ -152,7 +152,7 @@ describe('dumps', () => {
       dump: {
         inputs: [[]] as [][],
       },
-      handler: () => {
+      handler: (): void => {
         // eslint-disable-next-line no-throw-literal
         throw 'just a string'
       },
diff --git a/packages/devframe/src/rpc/dump/__tests__/static.test.ts b/packages/devframe/src/rpc/dump/__tests__/static.test.ts
@@ -223,7 +223,7 @@ describe('collectStaticRpcDump', () => {
         name: 'test:flaky',
         type: 'query',
         jsonSerializable: true,
-        handler: () => {
+        handler: (): void => {
           throw new TypeError('boom', { cause: new Error('inner') })
         },
         dump: {
@@ -261,7 +261,7 @@ describe('collectStaticRpcDump', () => {
         name: 'test:flaky-roundtrip',
         type: 'query',
         // default jsonSerializable: false → structured-clone shards
-        handler: () => {
+        handler: (): void => {
           const err = new TypeError('boom', { cause: new Error('inner') }) as Error & { tags?: unknown }
           err.tags = tags
           throw err
@@ -295,7 +295,7 @@ describe('collectStaticRpcDump', () => {
         name: 'test:flaky-non-json',
         type: 'query',
         jsonSerializable: true,
-        handler: () => {
+        handler: (): void => {
           const err = new Error('boom') as Error & { tags?: unknown }
           err.tags = new Map([['a', 1]])
           throw err
diff --git a/packages/devframe/src/rpc/dump/error.ts b/packages/devframe/src/rpc/dump/error.ts
@@ -30,7 +30,7 @@ function serializeWithSeen(error: unknown, seen: WeakSet<object>): RpcDumpRecord
   for (const key of Object.keys(error)) {
     if (key === 'name' || key === 'message' || key === 'cause')
       continue
-    out[key] = (error as Record<string, unknown>)[key]
+    out[key] = (error as unknown as Record<string, unknown>)[key]
   }
   return out
 }
diff --git a/packages/devframe/src/types/rpc-augments.ts b/packages/devframe/src/types/rpc-augments.ts
@@ -23,6 +23,27 @@ export interface DevframeRpcClientFunctions {
    * @internal
    */
   'devframe:streaming:upload-cancel': (channel: string, id: string) => Promise<void>
+  /**
+   * Full shared-state snapshot pushed from server to subscribed clients.
+   * Wired by `RpcSharedStateHost`; do not register manually.
+   *
+   * @internal
+   */
+  'devframe:rpc:client-state:updated': (key: string, fullState: any, syncId: string) => Promise<void>
+  /**
+   * Incremental shared-state patch pushed from server to subscribed clients.
+   * Wired by `RpcSharedStateHost`; do not register manually.
+   *
+   * @internal
+   */
+  'devframe:rpc:client-state:patch': (key: string, patches: any[], syncId: string) => Promise<void>
+  /**
+   * Server→client notification that the client's auth token was revoked.
+   * Broadcast by `revokeActiveConnectionsForToken`; do not register manually.
+   *
+   * @internal
+   */
+  'devframe:auth:revoked': () => Promise<void>
 }
 
 /**
@@ -92,6 +113,14 @@ export interface DevframeRpcServerFunctions {
    * @internal
    */
   'devframe:streaming:upload-end': (channel: string, id: string, error?: { name: string, message: string }) => Promise<void>
+  /**
+   * Anonymous-auth handshake the browser client issues on connect. The
+   * standalone server registers a noop auto-trust handler when `auth: false`;
+   * hosted adapters register the real handler. Do not register manually.
+   *
+   * @internal
+   */
+  'devframe:anonymous:auth': (payload: { authToken: string, ua: string, origin: string }) => Promise<{ isTrusted: boolean }>
 }
 
 /**
diff --git a/packages/devframe/src/types/rpc.ts b/packages/devframe/src/types/rpc.ts
@@ -4,7 +4,7 @@ import type { DevframeNodeRpcSessionMeta } from 'devframe/rpc/transports/ws-serv
 import type { SharedState } from 'devframe/utils/shared-state'
 import type { StreamReader, StreamSink } from 'devframe/utils/streaming-channel'
 import type { DevframeNodeContext } from './context'
-import type { DevframeRpcClientFunctions, DevframeRpcServerFunctions, DevframeRpcSharedStates } from './rpc-augments'
+import type { DevframeRpcClientFunctions, DevframeRpcServerFunctions } from './rpc-augments'
 
 export type { DevframeNodeRpcSessionMeta }
 
@@ -72,7 +72,7 @@ export interface RpcSharedStateGetOptions<T> {
 }
 
 export interface RpcSharedStateHost {
-  get: <T extends keyof DevframeRpcSharedStates>(key: T, options?: RpcSharedStateGetOptions<DevframeRpcSharedStates[T]>) => Promise<SharedState<DevframeRpcSharedStates[T]>>
+  get: <T extends object = any>(key: string, options?: RpcSharedStateGetOptions<T>) => Promise<SharedState<T>>
   keys: () => string[]
   /**
    * Subscribe to new shared-state keys becoming available. Fires when
diff --git a/packages/devframe/tsconfig.json b/packages/devframe/tsconfig.json
@@ -1,7 +1,8 @@
 {
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "composite": true,
     "lib": ["esnext", "dom"]
-  }
+  },
+  "include": ["src", "test", "scripts", "tsdown.config.ts"],
+  "exclude": ["dist", "node_modules"]
 }
diff --git a/packages/hub/package.json b/packages/hub/package.json
@@ -35,6 +35,7 @@
   "scripts": {
     "build": "tsdown",
     "watch": "tsdown --watch",
+    "typecheck": "tsc --noEmit",
     "prepack": "pnpm run build"
   },
   "peerDependencies": {
diff --git a/packages/hub/src/node/__tests__/context.test.ts b/packages/hub/src/node/__tests__/context.test.ts
@@ -1,3 +1,4 @@
+import type { DevframeDockEntry } from '../../types/docks'
 import { mkdtempSync } from 'node:fs'
 import { tmpdir } from 'node:os'
 import { join } from 'node:path'
@@ -22,7 +23,7 @@ describe('createHubContext shared state', () => {
       host: createHost(),
     })
 
-    const docks = await context.rpc.sharedState.get('devframe:docks')
+    const docks = await context.rpc.sharedState.get<DevframeDockEntry[]>('devframe:docks')
     expect(docks.value().map(dock => dock.id)).toEqual([
       '~terminals',
       '~messages',
diff --git a/packages/hub/src/node/__tests__/host-docks.test.ts b/packages/hub/src/node/__tests__/host-docks.test.ts
@@ -29,6 +29,7 @@ describe('devframeDockHost remote URL enrichment', () => {
       type: 'iframe',
       id: 'remote',
       title: 'Remote',
+      icon: 'ph:cube-duotone',
       url: 'https://remote.test/app#/inspect?tab=state',
       remote: true,
     })
@@ -47,6 +48,7 @@ describe('devframeDockHost remote URL enrichment', () => {
       type: 'iframe',
       id: 'remote',
       title: 'Remote',
+      icon: 'ph:cube-duotone',
       url: firstUrl,
       remote: true,
     })
@@ -66,6 +68,7 @@ describe('devframeDockHost remote URL enrichment', () => {
       type: 'iframe',
       id: 'remote',
       title: 'Remote',
+      icon: 'ph:cube-duotone',
       url: 'https://remote.test/app#section',
       remote: true,
     })
diff --git a/packages/hub/src/node/context.ts b/packages/hub/src/node/context.ts
@@ -13,6 +13,27 @@ import { DevframeMessagesHost as MessagesHostImpl } from './host-messages'
 import { DevframeTerminalsHost as TerminalsHostImpl } from './host-terminals'
 import { builtinHubRpcDeclarations } from './rpc-builtins'
 
+declare module 'devframe/types' {
+  interface DevframeRpcClientFunctions {
+    /**
+     * Server→client notification that terminal sessions changed. Broadcast
+     * by the hub context; a hub-aware client re-reads terminal state in
+     * response. Do not register manually.
+     *
+     * @internal
+     */
+    'devframe:terminals:updated': () => Promise<void>
+    /**
+     * Server→client notification that the message list changed. Broadcast
+     * by the hub context; a hub-aware client re-reads message state in
+     * response. Do not register manually.
+     *
+     * @internal
+     */
+    'devframe:messages:updated': () => Promise<void>
+  }
+}
+
 /**
  * Hub-augmented node context — extends devframe's framework-neutral
  * `DevframeNodeContext` with the hub-level subsystems (`docks`,
diff --git a/packages/hub/tsconfig.json b/packages/hub/tsconfig.json
@@ -1,7 +1,8 @@
 {
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "composite": true,
     "lib": ["esnext", "dom"]
-  }
+  },
+  "include": ["src", "tsdown.config.ts"],
+  "exclude": ["dist", "node_modules"]
 }
diff --git a/packages/nuxt/package.json b/packages/nuxt/package.json
@@ -32,6 +32,7 @@
   "scripts": {
     "build": "tsdown",
     "watch": "tsdown --watch",
+    "typecheck": "tsc --noEmit",
     "prepack": "pnpm run build"
   },
   "peerDependencies": {
diff --git a/packages/nuxt/tsconfig.json b/packages/nuxt/tsconfig.json
@@ -1,9 +1,9 @@
 {
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "composite": true,
     "lib": ["esnext", "dom"],
     "types": ["node"]
   },
-  "include": ["nuxt.d.ts", "src/**/*.ts", "../devframe/src/**/*.ts"]
+  "include": ["nuxt.d.ts", "src", "tsdown.config.ts"],
+  "exclude": ["dist", "node_modules"]
 }
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
@@ -15,6 +15,7 @@ trustPolicyExclude:
   - tinyexec@1.2.2
 packages:
   - packages/*
+  - plugins/*
   - examples/*
   - docs
 overrides:
diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -1,11 +1,9 @@
 {
   "compilerOptions": {
-    "composite": true,
     "target": "esnext",
     "lib": [
       "esnext"
     ],
-    "rootDir": ".",
     "module": "esnext",
     "moduleResolution": "Bundler",
     "paths": {
@@ -131,6 +129,7 @@
       ]
     },
     "resolveJsonModule": true,
+    "allowImportingTsExtensions": true,
     "strict": true,
     "noEmit": true,
     "isolatedDeclarations": false,
diff --git a/turbo.json b/turbo.json
@@ -1,7 +1,10 @@
 {
   "$schema": "https://turbo.build/schema.json",
-  "globalDependencies": ["pnpm-lock.yaml"],
+  "globalDependencies": ["pnpm-lock.yaml", "tsconfig.base.json"],
   "tasks": {
+    "typecheck": {
+      "dependsOn": ["^typecheck"]
+    },
     "devframe#build": {
       "outputLogs": "new-only",
       "outputs": ["dist/**"]

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,7 @@ function registerResourceHandlers(`
`226`	`226`	`}`
`227`	`227`
`228`	`228`	`if (parsed.kind === 'state') {`
`229`		`- const state = await ctx.rpc.sharedState.get(parsed.key as any)`
	`229`	`+ const state = await ctx.rpc.sharedState.get(parsed.key)`
`230`	`230`	`return {`
`231`	`231`	`contents: [`
`232`	`232`	`{`