Internal errors aren't passed to an `onError` callback

[gadomski]

I'd like to give users feedback when a COGLayer fails to load, but it appears as though onError doesn't get hit for some errors. E.g. I've added this to my layer:

      new COGLayer({
        id: "cog-" + geotiffHref,
        geotiff: geotiffHref,
        onError: () => console.log("hi there"),
      })

Then, a request that loads the GeoTIFF at https://maxar-opendata.s3.amazonaws.com/events/afghanistan-earthquake22/ard/42/120200201013/2022-06-27/10300100D4928800-visual.tif fails with:

No "hi there". I've dug a bit into deck.gl error handling, and haven't come with a solution that doesn't just implement a this.props.onError?.() manually. If that's the correct approach, happy to PR that.

[kylebarron]

Hmm. I didn't know an onError callback existed actually. Is that a generic deck.gl layer prop?

Any layer I define is currently thrown (you have to catch it I think?) instead of being propagated to onError

[gadomski]

Yeah, it looks like onError is on LayerProps. I wonder if the loading is happening in a worker, b/c this doesn't catch anything:

    try {
      layers.push(
        new COGLayer({
          id: "cog-" + geotiffHref,
          geotiff: geotiffHref,
        })
      );
    } catch (error) {
      console.error("Error loading COG layer:", error);
    }

[kylebarron]

Ah, sorry. Indeed, the COGLayer constructor isn't really doing much, just setting up the layer configuration. That won't catch the parsing. We should pass an exception to onError I suppose.