Add webhook sink MVP and fix env overrides recursion

Author: devblac

analytics/aggregation_additional_test.go

@@ -52,3 +52,21 @@ func TestAggregationEngineWeeklyMonthly(t *testing.T) {
 		t.Fatalf("unexpected monthly agg: %+v", monthly)
 	}
 }
+
+func TestComprehensiveMetricsTopMetrics(t *testing.T) {
+	metrics := NewComprehensiveMetrics()
+	now := time.Now().UTC()
+	metrics.OnEvent(core.Event{Type: core.EventPointsAdded, UserID: "u1", Metric: core.MetricXP, Delta: 10, Time: now})
+	metrics.OnEvent(core.Event{Type: core.EventPointsAdded, UserID: "u1", Metric: core.MetricPoints, Delta: 20, Time: now})
+	metrics.OnEvent(core.Event{Type: core.EventBadgeAwarded, UserID: "u1", Badge: "b1", Time: now})
+
+	top := metrics.GetTopMetrics(5)
+	totalPoints, ok := top["total_points_awarded"].(int64)
+	if !ok || totalPoints != 30 {
+		t.Fatalf("unexpected total points: %v", top["total_points_awarded"])
+	}
+	totalBadges, ok := top["total_badges_awarded"].(int64)
+	if !ok || totalBadges != 1 {
+		t.Fatalf("unexpected total badges: %v", top["total_badges_awarded"])
+	}
+}

config/config_test.go

@@ -24,6 +24,21 @@ func TestLoad(t *testing.T) {
 	assert.Equal(t, "json", cfg.Logging.Format)
 }
 
+func TestLoad_WithEnvOverrides(t *testing.T) {
+	t.Setenv("GAMIFYKIT_SECURITY_API_KEYS", "k1,k2")
+	t.Setenv("GAMIFYKIT_SECURITY_RATE_LIMIT_ENABLED", "true")
+	t.Setenv("GAMIFYKIT_SECURITY_RATE_LIMIT_RPM", "100")
+	t.Setenv("GAMIFYKIT_SECURITY_RATE_LIMIT_BURST", "50")
+	cfg, err := Load()
+	require.NoError(t, err)
+	require.Len(t, cfg.Security.APIKeys, 2)
+	assert.Contains(t, cfg.Security.APIKeys, "k1")
+	assert.Contains(t, cfg.Security.APIKeys, "k2")
+	assert.True(t, cfg.Security.EnableRateLimit)
+	assert.Equal(t, 100, cfg.Security.RateLimit.RequestsPerMinute)
+	assert.Equal(t, 50, cfg.Security.RateLimit.BurstSize)
+}
+
 func TestLoadFromFile(t *testing.T) {
 	// Create a temporary config file
 	configContent := `{

config/env.go

@@ -32,6 +32,16 @@ func loadFromEnvRecursive(v interface{}, prefix string) error {
 		field := val.Field(i)
 		fieldType := typ.Field(i)
 
+		// Recurse into nested structs to honor their env tags
+		if field.Kind() == reflect.Struct {
+			if field.CanAddr() {
+				if err := loadFromEnvRecursive(field.Addr().Interface(), prefix); err != nil {
+					return err
+				}
+			}
+			continue
+		}
+
 		// Get the env tag
 		envTag := fieldType.Tag.Get("env")
 		if envTag == "" {

integrations/webhook/webhook.go

@@ -0,0 +1,62 @@
+package webhook
+
+import (
+	"bytes"
+	"context"
+	"encoding/json"
+	"net/http"
+	"time"
+
+	"gamifykit/core"
+)
+
+// Sink posts domain events to configured HTTP endpoints.
+// It is synchronous for determinism; keep handlers fast or wrap with buffering if needed.
+type Sink struct {
+	client    *http.Client
+	endpoints []string
+}
+
+// Option configures a Sink.
+type Option func(*Sink)
+
+// WithClient overrides the HTTP client (defaults to 2s timeout).
+func WithClient(c *http.Client) Option {
+	return func(s *Sink) {
+		if c != nil {
+			s.client = c
+		}
+	}
+}
+
+// New creates a webhook sink.
+func New(endpoints []string, opts ...Option) *Sink {
+	s := &Sink{
+		client: &http.Client{Timeout: 2 * time.Second},
+	}
+	for _, opt := range opts {
+		opt(s)
+	}
+	s.endpoints = append([]string{}, endpoints...)
+	return s
+}
+
+// OnEvent posts the event JSON to all endpoints; errors are ignored for now (MVP).
+func (s *Sink) OnEvent(e core.Event) {
+	if len(s.endpoints) == 0 {
+		return
+	}
+	body, err := json.Marshal(e)
+	if err != nil {
+		return
+	}
+	for _, ep := range s.endpoints {
+		req, err := http.NewRequestWithContext(context.Background(), http.MethodPost, ep, bytes.NewReader(body))
+		if err != nil {
+			continue
+		}
+		req.Header.Set("Content-Type", "application/json")
+		_, _ = s.client.Do(req)
+	}
+}
+

integrations/webhook/webhook_test.go

@@ -0,0 +1,29 @@
+package webhook
+
+import (
+	"io/ioutil"
+	"net/http"
+	"net/http/httptest"
+	"sync/atomic"
+	"testing"
+
+	"gamifykit/core"
+)
+
+func TestSink_OnEventPostsToEndpoints(t *testing.T) {
+	var hits int32
+	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		atomic.AddInt32(&hits, 1)
+		_, _ = ioutil.ReadAll(r.Body)
+		_ = r.Body.Close()
+	}))
+	defer srv.Close()
+
+	sink := New([]string{srv.URL})
+	sink.OnEvent(core.NewPointsAdded("u1", core.MetricXP, 5, 5))
+
+	if atomic.LoadInt32(&hits) != 1 {
+		t.Fatalf("expected 1 hit, got %d", hits)
+	}
+}
+