From 3be8514726aee2d90890658640d107075033d453 Mon Sep 17 00:00:00 2001 From: noy4 Date: Mon, 4 Jul 2022 14:25:51 +0900 Subject: [PATCH 1/2] [ethers-v5] Separate import and type import --- packages/target-ethers-v5/src/codegen/index.ts | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/packages/target-ethers-v5/src/codegen/index.ts b/packages/target-ethers-v5/src/codegen/index.ts index 239e1a488..4f7e1b055 100644 --- a/packages/target-ethers-v5/src/codegen/index.ts +++ b/packages/target-ethers-v5/src/codegen/index.ts @@ -123,9 +123,8 @@ export function codegenContractTypings(contract: Contract, codegenConfig: Codege const imports = createImportsForUsedIdentifiers( { + ethers: ['BaseContract', 'BigNumber', 'Signer', 'utils'], 'type ethers': [ - 'BaseContract', - 'BigNumber', 'BigNumberish', 'BytesLike', 'CallOverrides', @@ -133,8 +132,6 @@ export function codegenContractTypings(contract: Contract, codegenConfig: Codege 'Overrides', 'PayableOverrides', 'PopulatedTransaction', - 'Signer', - 'utils', ], 'type @ethersproject/abi': ['FunctionFragment', 'Result', 'EventFragment'], 'type @ethersproject/providers': ['Listener', 'Provider'], @@ -207,16 +204,8 @@ export function codegenContractFactory( const imports = createImportsForUsedIdentifiers( { - ethers: [ - 'Signer', - 'utils', - 'Contract', - 'ContractFactory', - 'PayableOverrides', - 'BytesLike', - 'BigNumberish', - 'Overrides', - ], + ethers: ['Signer', 'utils', 'Contract', 'ContractFactory'], + 'type ethers': ['PayableOverrides', 'BytesLike', 'BigNumberish', 'Overrides'], 'type @ethersproject/providers': ['Provider', 'TransactionRequest'], }, source, From 5e20fa5d0313635b03956a3084ac2e089f222a6f Mon Sep 17 00:00:00 2001 From: noy4 Date: Mon, 4 Jul 2022 16:01:00 +0900 Subject: [PATCH 2/2] fix typo on CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5d16764c4..971486f0b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -30,7 +30,7 @@ set the current solidity version. ### Local linking Run `pnpm build` to build all packages or `pnpm watch` to start watching. Then enter desired package directory and run -`pmpm link`. +`pnpm link`. ### Debugging 🐞