power: supply: collie: Fix wakeup source leaks on device unbind

krzk · smb49 · commit 9840fe150632 · 2025-09-16T14:51:19.000+02:00
BugLink: https://bugs.launchpad.net/bugs/2120812 [ Upstream commit c73d19f89cb03c43abbbfa3b9caa1b8fc719764c ] Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20250406202730.55096-1-krzysztof.kozlowski@linaro.org Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Noah Wager <noah.wager@canonical.com> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
diff --git a/drivers/power/supply/collie_battery.c b/drivers/power/supply/collie_battery.c
@@ -440,6 +440,7 @@ static int collie_bat_probe(struct ucb1x00_dev *dev)
 
 static void collie_bat_remove(struct ucb1x00_dev *dev)
 {
+	device_init_wakeup(&ucb->dev, 0);
 	free_irq(gpiod_to_irq(collie_bat_main.gpio_full), &collie_bat_main);
 	power_supply_unregister(collie_bat_bu.psy);
 	power_supply_unregister(collie_bat_main.psy);

Original file line number	Diff line number	Diff line change
`@@ -440,6 +440,7 @@ static int collie_bat_probe(struct ucb1x00_dev *dev)`
`440`	`440`
`441`	`441`	`static void collie_bat_remove(struct ucb1x00_dev *dev)`
`442`	`442`	`{`
	`443`	`+ device_init_wakeup(&ucb->dev, 0);`
`443`	`444`	`free_irq(gpiod_to_irq(collie_bat_main.gpio_full), &collie_bat_main);`
`444`	`445`	`power_supply_unregister(collie_bat_bu.psy);`
`445`	`446`	`power_supply_unregister(collie_bat_main.psy);`