Skip to content

Commit f43e49b

Browse files
jmaneyrol-invnmehmetb0
authored andcommitted
iio: imu: inv_icm42600: fix spi burst write not supported
BugLink: https://bugs.launchpad.net/bugs/2106770 commit c0f866d upstream. Burst write with SPI is not working for all icm42600 chips. It was only used for setting user offsets with regmap_bulk_write. Add specific SPI regmap config for using only single write with SPI. Fixes: 9f9ff91 ("iio: imu: inv_icm42600: add SPI driver for inv_icm42600 driver") Cc: stable@vger.kernel.org Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> Link: https://patch.msgid.link/20241112-inv-icm42600-fix-spi-burst-write-not-supported-v2-1-97690dc03607@tdk.com Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Manuel Diewald <manuel.diewald@canonical.com> Signed-off-by: Mehmet Basaran <mehmet.basaran@canonical.com>
1 parent 06f799f commit f43e49b

File tree

3 files changed

+18
-1
lines changed

3 files changed

+18
-1
lines changed

drivers/iio/imu/inv_icm42600/inv_icm42600.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -362,6 +362,7 @@ struct inv_icm42600_state {
362362
typedef int (*inv_icm42600_bus_setup)(struct inv_icm42600_state *);
363363

364364
extern const struct regmap_config inv_icm42600_regmap_config;
365+
extern const struct regmap_config inv_icm42600_spi_regmap_config;
365366
extern const struct dev_pm_ops inv_icm42600_pm_ops;
366367

367368
const struct iio_mount_matrix *

drivers/iio/imu/inv_icm42600/inv_icm42600_core.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,21 @@ const struct regmap_config inv_icm42600_regmap_config = {
8888
};
8989
EXPORT_SYMBOL_NS_GPL(inv_icm42600_regmap_config, IIO_ICM42600);
9090

91+
/* define specific regmap for SPI not supporting burst write */
92+
const struct regmap_config inv_icm42600_spi_regmap_config = {
93+
.name = "inv_icm42600",
94+
.reg_bits = 8,
95+
.val_bits = 8,
96+
.max_register = 0x4FFF,
97+
.ranges = inv_icm42600_regmap_ranges,
98+
.num_ranges = ARRAY_SIZE(inv_icm42600_regmap_ranges),
99+
.volatile_table = inv_icm42600_regmap_volatile_accesses,
100+
.rd_noinc_table = inv_icm42600_regmap_rd_noinc_accesses,
101+
.cache_type = REGCACHE_RBTREE,
102+
.use_single_write = true,
103+
};
104+
EXPORT_SYMBOL_NS_GPL(inv_icm42600_spi_regmap_config, IIO_ICM42600);
105+
91106
struct inv_icm42600_hw {
92107
uint8_t whoami;
93108
const char *name;

drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ static int inv_icm42600_probe(struct spi_device *spi)
5959
return -EINVAL;
6060
chip = (uintptr_t)match;
6161

62-
regmap = devm_regmap_init_spi(spi, &inv_icm42600_regmap_config);
62+
/* use SPI specific regmap */
63+
regmap = devm_regmap_init_spi(spi, &inv_icm42600_spi_regmap_config);
6364
if (IS_ERR(regmap))
6465
return PTR_ERR(regmap);
6566

0 commit comments

Comments
 (0)