gpio: pca953x: log an error when failing to get the reset GPIO

lucaceresoli · mehmetb0 · commit 218d45a99bb3 · 2025-06-15T10:37:26.000+03:00
BugLink: https://bugs.launchpad.net/bugs/2111953 [ Upstream commit 7cef813 ] When the dirver fails getting this GPIO, it fails silently. Log an error message to make debugging a lot easier by just reading dmesg. Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Fixes: 054ccde ("gpio: pca953x: Add optional reset gpio control") Link: https://lore.kernel.org/r/20241219-pca953x-log-no-reset-gpio-v1-1-9aa7bcc45ead@bootlin.com Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Manuel Diewald <manuel.diewald@canonical.com> Signed-off-by: Mehmet Basaran <mehmet.basaran@canonical.com>
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
@@ -1088,7 +1088,8 @@ static int pca953x_probe(struct i2c_client *client)
 		 */
 		reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
 		if (IS_ERR(reset_gpio))
-			return PTR_ERR(reset_gpio);
+			return dev_err_probe(dev, PTR_ERR(reset_gpio),
+					     "Failed to get reset gpio\n");
 	}
 
 	chip->client = client;

Original file line number	Diff line number	Diff line change
`@@ -1088,7 +1088,8 @@ static int pca953x_probe(struct i2c_client *client)`
`1088`	`1088`	`*/`
`1089`	`1089`	`reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);`
`1090`	`1090`	`if (IS_ERR(reset_gpio))`
`1091`		`- return PTR_ERR(reset_gpio);`
	`1091`	`+ return dev_err_probe(dev, PTR_ERR(reset_gpio),`
	`1092`	`+ "Failed to get reset gpio\n");`
`1092`	`1093`	`}`
`1093`	`1094`
`1094`	`1095`	`chip->client = client;`