From fb0f74c965983bd7fd7fab76c3408d9601264b69 Mon Sep 17 00:00:00 2001 From: Adam Wildavsky Date: Sat, 4 Jul 2026 18:51:46 -0400 Subject: [PATCH 1/2] Fix dotnet doc error check and remove debugging notes Remove a duplicate SolveBoard example that cast the return code to bool (inverted success/failure), and drop stray debugger comments from SolveAllBoards wrappers. Co-authored-by: Cursor --- docs/dotnet_interface.md | 4 ---- dotnet/DDS_Core/DDS.cs | 3 +-- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/docs/dotnet_interface.md b/docs/dotnet_interface.md index 64e19751..573f9381 100644 --- a/docs/dotnet_interface.md +++ b/docs/dotnet_interface.md @@ -367,10 +367,6 @@ public void sample() throw new InvalidOperationException(error); } - if (!(int)ctx.SolveBoard(deal, -1, 1, 0, out FutureTricks fut)) - throw new InvalidOperationException("DDS_Core failed to solve the board."); - - ... var ddTableDeal = new() {Cards = hands }; diff --git a/dotnet/DDS_Core/DDS.cs b/dotnet/DDS_Core/DDS.cs index 7126e4fd..f80e4cff 100644 --- a/dotnet/DDS_Core/DDS.cs +++ b/dotnet/DDS_Core/DDS.cs @@ -189,7 +189,6 @@ public int SolveAllBoards( in Boards bop { solved = default; - //Note: To step into c++ code you must set a break in c++? var rc = DdsNative.SolveAllBoardsBin( bop , out solved); @@ -638,4 +637,4 @@ private static void ThrowIfError(in int result, in string functionName) throw new InvalidOperationException($"{functionName} failed with code {result}: {result.GetRCErrorMessage()}"); } #endregion -} +} \ No newline at end of file From ca0e80da71176d00e76346096bfd85715b9c8c30 Mon Sep 17 00:00:00 2001 From: Adam Wildavsky Date: Sun, 5 Jul 2026 01:07:42 -0400 Subject: [PATCH 2/2] Removed second stray comment. --- dotnet/DDS_Core/DDS.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/dotnet/DDS_Core/DDS.cs b/dotnet/DDS_Core/DDS.cs index f80e4cff..c23850de 100644 --- a/dotnet/DDS_Core/DDS.cs +++ b/dotnet/DDS_Core/DDS.cs @@ -169,7 +169,6 @@ public int SolveAllBoards( in BoardsPBN boards , out SolvedBoards solved) { solved = default; - //Note: To step into c++ code you must set a break in c++? var rc = DdsNative.SolveAllBoards( boards , out solved);