Skip to content

Should [HandleError] attribute be removed from the base controllers? #65

@quirijnslings

Description

@quirijnslings

I got this comment from Rafeeq (a good MVC developer);

[17-1-2016 8:59:01] Rafeeq: Is it good too have [HandleError] attribute on framework level..
I believe it should be removed..
[17-1-2016 8:59:13] Rafeeq: https://github.com/dd4t/DD4T.MVC/blob/develop/source/DD4T.Mvc/Controllers/ModelControllerBase.cs#L65
https://github.com/dd4t/DD4T.MVC/blob/develop/source/DD4T.Mvc/Controllers/TridionControllerBase.cs#L27
[17-1-2016 8:59:41] Rafeeq: It should be handled at application level right??
[17-1-2016 8:59:50] Rafeeq: rather than framework level..

I think he has a point. Any objections if we remove the HandleError attributes?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions