feat: only leave code matchers and chai-retry-plugin

delete all other mocha hooking functionality, as it appears to hurt our ability to parallelize tests in Dazl

Author: AviVahl

packages/testing/README.md

@@ -1,6 +1,4 @@
 import * as chai from 'chai';
-import { isAdjustedTimeout } from '../timeouts.helpers.js';
-import { scaleTimeout } from '../timeouts.js';
 import type { PromiseLikeAssertion } from '../types.js';
 import { retryFunctionAndAssertions } from './helpers.js';
 import type { Assertion, AssertionMethod, AssertionStackItem, FunctionToRetry, RetryOptions } from './types.js';
@@ -44,16 +42,9 @@ export const chaiRetryPlugin = function (_: Chai.ChaiStatic, utils: Chai.ChaiUti
                     `Please pass function to \`expect\` in order to use \`chaiRetryPlugin\`. ${utils.inspect(functionToRetry)} is not a function.`,
                 );
             }
-            if (isAdjustedTimeout(retryOptions)) {
-                throw new Error(
-                    `retry is debug safe, don't use it with debugSafeTimeout, use { timeout: X, ... } instead.`,
-                );
-            }
 
             const defaultRetryOptions: Required<RetryOptions> = { timeout: 8_000, retries: Infinity, delay: 0 };
             const options: Required<RetryOptions> = { ...defaultRetryOptions, ...retryOptions };
-            options.delay = scaleTimeout(options.delay);
-            options.timeout = scaleTimeout(options.timeout);
 
             const assertionStack: AssertionStackItem[] = [];
             // Fake assertion object for catching calls of chained methods

packages/testing/src/chai-retry-plugin/chai-retry-plugin.ts

@@ -1,6 +1,5 @@
 import * as chai from 'chai';
 import { deferred, timeout } from 'promise-assist';
-import { adjustCurrentTestTimeout, isDebugMode } from '../timeouts.js';
 import { chaiMethodsThatHandleFunction } from './constants.js';
 import type { AssertionMethod, RetryAndAssertArguments } from './types.js';
 
@@ -33,8 +32,7 @@ export const retryFunctionAndAssertions = async (retryParams: RetryAndAssertArgu
     const performRetries = async () => {
         let delay: Promise<void>;
 
-        for (let retriesCount = 0; (retriesCount < options.retries && !didTimeout) || isDebugMode(); retriesCount++) {
-            const time = Date.now();
+        for (let retriesCount = 0; retriesCount < options.retries && !didTimeout; retriesCount++) {
             try {
                 /**
                  * If assertion chain includes such method as `change`, `decrease` or `increase` that means function passed to
@@ -50,7 +48,6 @@ export const retryFunctionAndAssertions = async (retryParams: RetryAndAssertArgu
             } catch (error: any) {
                 if (!didTimeout) {
                     assertionError = error as Error;
-                    adjustTest(time, options.delay);
                     ({ cancel, delay } = sleep(options.delay));
                     await delay;
                 }
@@ -62,7 +59,7 @@ export const retryFunctionAndAssertions = async (retryParams: RetryAndAssertArgu
 
     const getTimeoutError = () => `Timed out after ${options.timeout}ms.`;
 
-    if (isDebugMode() || !options.timeout) {
+    if (!options.timeout) {
         return performRetries();
     } else {
         return timeout(performRetries(), options.timeout, getTimeoutError).catch((err) => {
@@ -96,14 +93,6 @@ const updateAssertion = async (
     propertyName: keyof Chai.Assertion,
 ) => (method && args ? await method.apply(assertion, args) : (assertion[propertyName] as Chai.Assertion));
 
-const adjustTest = (time: number, delay: number): number => {
-    const now = Date.now();
-    const diff = now - time;
-
-    adjustCurrentTestTimeout(diff + delay);
-    return now + delay;
-};
-
 const sleep = (ms: number) => {
     const { promise, resolve, reject } = deferred();
     const timeoutId = setTimeout(resolve, ms);

packages/testing/src/chai-retry-plugin/helpers.ts

@@ -1,26 +1,6 @@
 /**
  * @packageDocumentation
  * Utils for making mocha + chai testing easy and fun
- *
- * @remarks
- * [[[h 3 Env variables]]]
- * - DEBUG=true/positive number env variable will set test timeouts and time scale to infinity so tests (that don't explicitly override timeout) will not time out on breakpoints
- *
- * - TIMEOUT_MULTIPLIER=number env variable will multiply all test timeouts by the given number
- *
- * [[[h 3 Test timeout manipulation]]]
- *
- * - {@link scaleTimeout} multiplies timeouts when debugging or running on slow CI machines, based on TIMEOUT_MULTIPLIER and DEBUG env variables
- *
- * - {@link adjustTestTime} adjusts current test timeout (for use in non step async actions)
- *
- * - {@link locatorTimeout} creates a locator timeout and adjust the current test
- *
  */
-export * from './safe-fake-timer.js';
-export * from './dispose.js';
-export * from './randomize-tests-order.js';
-export * from './mocha-ctx.js';
 export * from './chai-retry-plugin/index.js';
 export * from './code-matchers/index.js';
-export * from './timeouts.js';