Skip to content

Make this function more efficient by using a single query to get all the rowids in the table using one query #872

@github-actions

Description

@github-actions

Currently this function is called every time to fetch the boundary, instead of this a change is expected here that can fetch all the rowids at once, this might significantly improve the query performance and reduce repeated db calls.

// TODO: Make this function more efficient by using a single query to get all the rowids in the table using one query
func (o *Oracle) splitViaTableIteration(ctx context.Context, stream types.StreamInterface, avgRowSize float64) (*types.Set[types.Chunk], error) {
chunks := types.NewSet[types.Chunk]()
var minRowId, maxRowId string
query := jdbc.OracleMinMaxRowIDQuery(stream)


This issue was generated by todo-issue based on a TODO comment in 8804519. It's been assigned to @vaibhav-datazip because they committed the code.

Metadata

Metadata

Assignees

Labels

beginnereasy issues for beginner contributorsgood first issueGood for newcomers

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions