FormDialog: DOM node not disposed on modal hide

[thinkh]

Environment

• Release number or git hash: cdac1c1
• Browser: Chrome 105
• Deployed / Local: Both

---

Steps to reproduce the bug

0. Open https://ordino-daily.caleydoapp.org/app/
1. Open a list of cell lines
2. Add a "Gene Score (Single)" dialog
3. Close dialog with close button

Observed Behavior

Check Elements in Chrome Dev tools.

The element is still there even though the dialog was closed.

Expected Behavior

Modal DOM elements should be removed when the modal dialog closes.

Context

The modal should be disposed in the dialog's destroy() method:

tdp_core/src/components/dialogs.ts

Lines 135 to 140 in b49b0e8

	destroy() {
	if (--Dialog.openDialogs > 0) {
	$('body').addClass('modal-open');
	}
	return this.bsModal.dispose();
	}

See also the Bootstrap Modal documentation.

---

Thanks for taking the time to fill out this bug report 🤗
Make sure there aren't any open/closed issues for this topic 😃