Skip to content
This repository was archived by the owner on Apr 17, 2018. It is now read-only.

Commit c874faf

Browse files
committed
Switch over to using ContextualValidator#add.
1 parent f1a598a commit c874faf

13 files changed

Lines changed: 18 additions & 77 deletions

lib/dm-validations/validators/absent_field_validator.rb

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,8 @@ module ValidatesAbsence
4848
# # all three attributes are blank
4949
# end
5050
#
51-
def validates_absence_of(*fields)
52-
DataMapper::Validations.add_validator_to_context(
53-
self,
54-
DataMapper::Validations.opts_from_validator_args(fields),
55-
fields,
56-
DataMapper::Validations::AbsenceValidator
57-
)
51+
def validates_absence_of(*args)
52+
validators.add(AbsenceValidator, *args)
5853
end
5954

6055
deprecate :validates_absent, :validates_absence_of

lib/dm-validations/validators/acceptance_validator.rb

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,8 @@ module ValidatesAcceptance
6868
# # and
6969
# # terms_accepted is one of ["1", 1, "true", true, "t"]
7070
#
71-
def validates_acceptance_of(*fields)
72-
DataMapper::Validations.add_validator_to_context(
73-
self,
74-
DataMapper::Validations.opts_from_validator_args(fields),
75-
fields,
76-
DataMapper::Validations::AcceptanceValidator
77-
)
71+
def validates_acceptance_of(*args)
72+
validators.add(AcceptanceValidator, *args)
7873
end
7974

8075
deprecate :validates_is_accepted, :validates_acceptance_of

lib/dm-validations/validators/block_validator.rb

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,11 @@ def validates_with_block(*fields, &block)
5050
method_name = "__validates_with_block_#{@__validates_with_block_count}".to_sym
5151
define_method(method_name, block)
5252

53-
opts = DataMapper::Validations.opts_from_validator_args(fields)
54-
opts[:method] = method_name
53+
options = fields.last.is_a?(Hash) ? fields.last.pop.dup : {}
54+
options[:method] = method_name
55+
fields = [method_name] if fields.empty?
5556

56-
DataMapper::Validations.add_validator_to_context(
57-
self,
58-
opts,
59-
fields.empty? ? [method_name] : fields,
60-
DataMapper::Validations::MethodValidator
61-
)
57+
validators.add(MethodValidator, fields, options)
6258
end
6359
end # module ValidatesWithMethod
6460
end # module Validations

lib/dm-validations/validators/confirmation_validator.rb

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,12 +82,7 @@ module ValidatesConfirmation
8282
# # email == email_repeated
8383
#
8484
def validates_confirmation_of(*fields)
85-
DataMapper::Validations.add_validator_to_context(
86-
self,
87-
DataMapper::Validations.opts_from_validator_args(fields),
88-
fields,
89-
DataMapper::Validations::ConfirmationValidator
90-
)
85+
validators.add(ConfirmationValidator, *fields)
9186
end
9287

9388
deprecate :validates_is_confirmed, :validates_confirmation_of

lib/dm-validations/validators/format_validator.rb

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -115,12 +115,7 @@ module ValidatesFormat
115115
# # zip_code is a string of 5 digits
116116
#
117117
def validates_format_of(*fields)
118-
DataMapper::Validations.add_validator_to_context(
119-
self,
120-
DataMapper::Validations.opts_from_validator_args(fields),
121-
fields,
122-
DataMapper::Validations::FormatValidator
123-
)
118+
validators.add(FormatValidator, *fields)
124119
end
125120

126121
deprecate :validates_format, :validates_format_of

lib/dm-validations/validators/generic_validator.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ def get_resource_property(resource, property_name)
178178
model = resource.model if resource.respond_to?(:model)
179179
repository = resource.repository if model
180180
properties = model.properties(repository.name) if model
181-
properties[property_name] if properties
181+
properties[property_name] if properties
182182
end
183183

184184
end # class GenericValidator

lib/dm-validations/validators/length_validator.rb

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -240,12 +240,7 @@ module ValidatesLength
240240
# # just_right is between 1 and 10 (inclusive of both 1 and 10)
241241
#
242242
def validates_length_of(*fields)
243-
DataMapper::Validations.add_validator_to_context(
244-
self,
245-
DataMapper::Validations.opts_from_validator_args(fields),
246-
fields,
247-
DataMapper::Validations::LengthValidator
248-
)
243+
validators.add(LengthValidator, *fields)
249244
end
250245

251246
deprecate :validates_length, :validates_length_of

lib/dm-validations/validators/method_validator.rb

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,7 @@ module ValidatesWithMethod
5757
# # wrong zip code" unless zip_code == "94301"
5858
# end
5959
def validates_with_method(*fields)
60-
DataMapper::Validations.add_validator_to_context(
61-
self,
62-
DataMapper::Validations.opts_from_validator_args(fields),
63-
fields,
64-
DataMapper::Validations::MethodValidator
65-
)
60+
validators.add(MethodValidator, *fields)
6661
end
6762
end # module ValidatesWithMethod
6863
end # module Validations

lib/dm-validations/validators/numeric_validator.rb

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -173,12 +173,7 @@ module ValidatesNumericality
173173
# Use to restrict allowed values to integers.
174174
#
175175
def validates_numericality_of(*fields)
176-
DataMapper::Validations.add_validator_to_context(
177-
self,
178-
DataMapper::Validations.opts_from_validator_args(fields),
179-
fields,
180-
DataMapper::Validations::NumericalityValidator
181-
)
176+
validators.add(NumericalityValidator, *fields)
182177
end
183178

184179
deprecate :validates_is_number, :validates_numericality_of

lib/dm-validations/validators/primitive_validator.rb

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,7 @@ module ValidatesPrimitiveType
4949
# # casted into a Date object.
5050
# end
5151
def validates_primitive_type_of(*fields)
52-
DataMapper::Validations.add_validator_to_context(
53-
self,
54-
DataMapper::Validations.opts_from_validator_args(fields),
55-
fields,
56-
DataMapper::Validations::PrimitiveTypeValidator
57-
)
52+
validators.add(PrimitiveTypeValidator, *fields)
5853
end
5954

6055
deprecate :validates_is_primitive, :validates_primitive_type_of

0 commit comments

Comments
 (0)