Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Commit f989575

Browse files
committed
format and unused method
1 parent acad4e4 commit f989575

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

data_diff/dbt.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,15 @@
77
import rich
88
from rich.prompt import Prompt
99

10-
from data_diff.errors import DataDiffCustomSchemaNoConfigError, DataDiffDbtProjectVarsNotFoundError, DataDiffNoAPIKeyError, DataDiffNoDatasourceIdError
10+
from data_diff.errors import (
11+
DataDiffCustomSchemaNoConfigError,
12+
DataDiffDbtProjectVarsNotFoundError,
13+
DataDiffNoAPIKeyError,
14+
DataDiffNoDatasourceIdError,
15+
)
1116

1217
from . import connect_to_table, diff_tables, Algorithm
13-
from .cloud import DatafoldAPI, TCloudApiDataDiff, TCloudApiOrgMeta, get_or_create_data_source
18+
from .cloud import DatafoldAPI, TCloudApiDataDiff, TCloudApiOrgMeta
1419
from .dbt_parser import DbtParser, TDatadiffConfig
1520
from .tracking import (
1621
bool_ask_for_email,
@@ -66,7 +71,6 @@ def dbt_diff(
6671
config = dbt_parser.get_datadiff_config()
6772
_initialize_events(dbt_parser.dbt_user_id, dbt_parser.dbt_version, dbt_parser.dbt_project_id)
6873

69-
7074
if not state and not (config.prod_database or config.prod_schema):
7175
doc_url = "https://docs.datafold.com/development_testing/open_source#configure-your-dbt-project"
7276
raise DataDiffDbtProjectVarsNotFoundError(
@@ -407,7 +411,7 @@ def _initialize_events(dbt_user_id: Optional[str], dbt_version: Optional[str], d
407411

408412

409413
def _email_signup() -> None:
410-
email_regex = r'^[\w\.\+-]+@[\w\.-]+\.\w+$'
414+
email_regex = r"^[\w\.\+-]+@[\w\.-]+\.\w+$"
411415
prompt = "\nWould you like to be notified when a new data-diff version is available?\n\nEnter email or leave blank to opt out (we'll only ask once).\n"
412416

413417
if bool_ask_for_email():

data_diff/errors.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,10 @@ class DataDiffDbtSelectVersionTooLowError(Exception):
4949
class DataDiffCustomSchemaNoConfigError(Exception):
5050
"Raised when a model has a custom schema, but there is no prod_custom_schema config. (And not using --state)."
5151

52+
5253
class DataDiffNoAPIKeyError(Exception):
5354
"Raised when using --cloud but no API key is present in the DATAFOLD_API_KEY env var or keyring"
5455

56+
5557
class DataDiffNoDatasourceIdError(Exception):
5658
"Raised when using --cloud but no datasource_id was found in dbt_project.yml"

tests/test_dbt.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -788,9 +788,7 @@ def test_diff_is_cloud_no_ds_id(
788788
@patch("data_diff.dbt._cloud_diff")
789789
@patch("data_diff.dbt_parser.DbtParser.__new__")
790790
@patch("builtins.input", return_value="n")
791-
def test_diff_is_cloud_no_api_key(
792-
self, _, mock_dbt_parser, mock_cloud_diff, mock_local_diff, mock_get_diff_vars
793-
):
791+
def test_diff_is_cloud_no_api_key(self, _, mock_dbt_parser, mock_cloud_diff, mock_local_diff, mock_get_diff_vars):
794792
mock_dbt_parser_inst = Mock()
795793
mock_model = Mock()
796794
config = TDatadiffConfig(prod_database="prod_db", prod_schema="prod_schema")

0 commit comments

Comments
 (0)