Eliminate unused specification of JSON column types

Author: Sergey Vasilyev

data_diff/sqeleton/abcs/database_types.py

@@ -138,18 +138,6 @@ class JSON(ColType):
     pass
 
 
-class RedShiftSuper(JSON):
-    pass
-
-
-class PostgresqlJSON(JSON):
-    pass
-
-
-class PostgresqlJSONB(JSON):
-    pass
-
-
 @dataclass
 class Integer(NumericType, IKey):
     precision: int = 0

data_diff/sqeleton/databases/postgresql.py

@@ -1,5 +1,6 @@
 from ..abcs.database_types import (
     DbPath,
+    JSON,
     Timestamp,
     TimestampTZ,
     Float,
@@ -11,8 +12,6 @@
     FractionalType,
     Boolean,
     Date,
-    PostgresqlJSON,
-    PostgresqlJSONB
 )
 from ..abcs.mixins import AbstractMixin_MD5, AbstractMixin_NormalizeValue
 from .base import BaseDialect, ThreadedDatabase, import_helper, ConnectError, Mixin_Schema
@@ -51,7 +50,7 @@ def normalize_number(self, value: str, coltype: FractionalType) -> str:
     def normalize_boolean(self, value: str, _coltype: Boolean) -> str:
         return self.to_string(f"{value}::int")
 
-    def normalize_json(self, value: str, _coltype: PostgresqlJSON) -> str:
+    def normalize_json(self, value: str, _coltype: JSON) -> str:
         return f"{value}::text"
 
 
@@ -81,12 +80,10 @@ class PostgresqlDialect(BaseDialect, Mixin_Schema):
         "character varying": Text,
         "varchar": Text,
         "text": Text,
-        # JSON
-        "json": PostgresqlJSON,
-        "jsonb": PostgresqlJSONB,
-        # UUID
+
+        "json": JSON,
+        "jsonb": JSON,
         "uuid": Native_UUID,
-        # Boolean
         "boolean": Boolean,
     }
 

data_diff/sqeleton/databases/redshift.py

@@ -1,11 +1,11 @@
 from typing import List, Dict
 from ..abcs.database_types import (
     Float,
+    JSON,
     TemporalType,
     FractionalType,
     DbPath,
     TimestampTZ,
-    RedShiftSuper
 )
 from ..abcs.mixins import AbstractMixin_MD5
 from .postgresql import (
@@ -47,7 +47,7 @@ def normalize_timestamp(self, value: str, coltype: TemporalType) -> str:
     def normalize_number(self, value: str, coltype: FractionalType) -> str:
         return self.to_string(f"{value}::decimal(38,{coltype.precision})")
 
-    def normalize_json(self, value: str, _coltype: RedShiftSuper) -> str:
+    def normalize_json(self, value: str, _coltype: JSON) -> str:
         return f'nvl2({value}, json_serialize({value}), NULL)'
 
 
@@ -57,8 +57,7 @@ class Dialect(PostgresqlDialect):
         **PostgresqlDialect.TYPE_CLASSES,
         "double": Float,
         "real": Float,
-        # JSON
-        "super": RedShiftSuper
+        "super": JSON,
     }
     SUPPORTS_INDEXES = False