Merge pull request #38 from datafold/fix-type-conversion-in-presto

Fix type conversion in Presto

Author: vvkh

sqeleton/databases/presto.py

@@ -93,6 +93,9 @@ def explain_as_text(self, query: str) -> str:
         return f"EXPLAIN (FORMAT TEXT) {query}"
 
     def type_repr(self, t) -> str:
+        if isinstance(t, TimestampTZ):
+            return f"timestamp with time zone"
+
         try:
             return {float: "REAL"}[t]
         except KeyError:
@@ -141,11 +144,6 @@ def set_timezone_to_utc(self) -> str:
     def current_timestamp(self) -> str:
         return "current_timestamp"
 
-    def type_repr(self, t) -> str:
-        if isinstance(t, TimestampTZ):
-            return f"timestamp with time zone"
-        return super().type_repr(t)
-
 
 class Presto(Database):
     dialect = Dialect()

tests/test_database.py

@@ -73,6 +73,24 @@ def test_table_list(self):
         db.query(tbl.drop())
         assert not db.query(q)
 
+    def test_type_mapping(self):
+        name = "tbl_" + random_table_suffix()
+        db = get_conn(self.db_cls)
+        tbl = table(db.parse_table_name(name), schema={
+            "int": int,
+            "float": float,
+            "datetime": datetime,
+            "str": str,
+            "bool": bool,
+        })
+        q = db.dialect.list_tables(db.default_schema, name)
+        assert not db.query(q)
+
+        db.query(tbl.create())
+        self.assertEqual(db.query(q, List[str]), [name])
+
+        db.query(tbl.drop())
+        assert not db.query(q)
 
 @test_each_database
 class TestQueries(unittest.TestCase):