Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Commit 30f5c23

Browse files
authored
Merge pull request #126 from datafold/int-tests
tests: add bigint/int
2 parents 42795b5 + 81b11c6 commit 30f5c23

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

data_diff/databases/mysql.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ class MySQL(ThreadedDatabase):
2020
"float": Float,
2121
"decimal": Decimal,
2222
"int": Integer,
23+
"bigint": Integer,
2324
}
2425
ROUNDS_ON_PREC_LOSS = True
2526

tests/test_database_types.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ def __next__(self) -> float:
170170
"int": [
171171
# "smallint", # 2 bytes
172172
"int", # 4 bytes
173-
# "bigint", # 8 bytes
173+
"bigint", # 8 bytes
174174
],
175175
# https://www.postgresql.org/docs/current/datatype-datetime.html
176176
"datetime_no_timezone": [
@@ -193,7 +193,7 @@ def __next__(self) -> float:
193193
# "smallint", # 2 bytes
194194
# "mediumint", # 3 bytes
195195
"int", # 4 bytes
196-
# "bigint", # 8 bytes
196+
"bigint", # 8 bytes
197197
],
198198
# https://dev.mysql.com/doc/refman/8.0/en/datetime.html
199199
"datetime_no_timezone": [
@@ -228,8 +228,8 @@ def __next__(self) -> float:
228228
"int": [
229229
# all 38 digits with 0 precision, don't need to test all
230230
"int",
231-
# "integer",
232-
# "bigint",
231+
"integer",
232+
"bigint",
233233
# "smallint",
234234
# "tinyint",
235235
# "byteint"
@@ -281,7 +281,7 @@ def __next__(self) -> float:
281281
# "smallint", # 2 bytes
282282
# "mediumint", # 3 bytes
283283
"int", # 4 bytes
284-
# "bigint", # 8 bytes
284+
"bigint", # 8 bytes
285285
],
286286
"datetime_no_timezone": [
287287
"timestamp",

0 commit comments

Comments
 (0)