Skip to content

Commit 6bc4a4f

Browse files
committed
refactor: code optimization
1 parent 0ccf47d commit 6bc4a4f

File tree

3 files changed

+14
-32
lines changed

3 files changed

+14
-32
lines changed

backend/apps/datasource/crud/datasource.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
from apps.db.constant import DB
1212
from apps.db.db import get_tables, get_fields, exec_sql, check_connection
1313
from apps.db.engine import get_engine_config, get_engine_conn
14-
from apps.db.type import db_type_relation
1514
from common.core.deps import SessionDep, CurrentUser, Trans
1615
from common.utils.utils import deepcopy_ignore_extra
1716
from .table import get_tables_by_ds_id
@@ -70,7 +69,7 @@ def create_ds(session: SessionDep, trans: Trans, user: CurrentUser, create_ds: C
7069
ds.create_by = user.id
7170
ds.oid = user.oid if user.oid is not None else 1
7271
ds.status = "Success"
73-
ds.type_name = db_type_relation()[ds.type]
72+
ds.type_name = DB.get_db(ds.type).db_name
7473
record = CoreDatasource(**ds.model_dump())
7574
session.add(record)
7675
session.flush()

backend/apps/db/constant.py

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,19 +13,20 @@ def __init__(self, type_name):
1313

1414

1515
class DB(Enum):
16-
mysql = ('mysql', '`', '`', ConnectType.sqlalchemy)
17-
sqlServer = ('sqlServer', '[', ']', ConnectType.sqlalchemy)
18-
pg = ('pg', '"', '"', ConnectType.sqlalchemy)
19-
excel = ('excel', '"', '"', ConnectType.sqlalchemy)
20-
oracle = ('oracle', '"', '"', ConnectType.sqlalchemy)
21-
ck = ('ck', '"', '"', ConnectType.sqlalchemy)
22-
dm = ('dm', '"', '"', ConnectType.py_driver)
23-
doris = ('doris', '`', '`', ConnectType.py_driver)
24-
redshift = ('redshift', '"', '"', ConnectType.py_driver)
25-
es = ('es', '"', '"', ConnectType.py_driver)
26-
27-
def __init__(self, type, prefix, suffix, connect_type: ConnectType):
16+
mysql = ('mysql', 'MySQL', '`', '`', ConnectType.sqlalchemy)
17+
sqlServer = ('sqlServer', 'Microsoft SQL Server', '[', ']', ConnectType.sqlalchemy)
18+
pg = ('pg', 'PostgreSQL', '"', '"', ConnectType.sqlalchemy)
19+
excel = ('excel', 'Excel/CSV', '"', '"', ConnectType.sqlalchemy)
20+
oracle = ('oracle', 'Oracle', '"', '"', ConnectType.sqlalchemy)
21+
ck = ('ck', 'ClickHouse', '"', '"', ConnectType.sqlalchemy)
22+
dm = ('dm', '达梦', '"', '"', ConnectType.py_driver)
23+
doris = ('doris', 'Apache Doris', '`', '`', ConnectType.py_driver)
24+
redshift = ('redshift', 'AWS Redshift', '"', '"', ConnectType.py_driver)
25+
es = ('es', 'Elasticsearch', '"', '"', ConnectType.py_driver)
26+
27+
def __init__(self, type, db_name, prefix, suffix, connect_type: ConnectType):
2828
self.type = type
29+
self.db_name = db_name
2930
self.prefix = prefix
3031
self.suffix = suffix
3132
self.connect_type = connect_type

backend/apps/db/type.py

Lines changed: 0 additions & 18 deletions
This file was deleted.

0 commit comments

Comments
 (0)