From 083c164da8b13c643cddabfbeb5a756a87451be4 Mon Sep 17 00:00:00 2001 From: barry0451 Date: Wed, 1 Apr 2026 18:17:36 +0000 Subject: [PATCH 1/2] fix: render schemas in ODCS HTML template (fixes #880) --- CHANGELOG.md | 1 + tests/test_export_html.py | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 226136498..efd50dfea 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fix SQL export generating multiple PRIMARY KEY constraints for composite keys (#1026) - Preserve parametrized physicalTypes for SQL export (#1086) - Fix incorrect SQL type mappings: SQL Server `double`/`jsonb`, MySQL bare `varchar`, missing Trino types (#1110) +- Fix ODCS HTML export not rendering schemas due to wrong attribute name (`schema` vs `schema_`) (#880) ## [0.11.7] - 2026-03-24 diff --git a/tests/test_export_html.py b/tests/test_export_html.py index dd50e7349..89612bccd 100644 --- a/tests/test_export_html.py +++ b/tests/test_export_html.py @@ -29,3 +29,13 @@ def test_cli_with_output(tmp_path: Path): ) assert result.exit_code == 0 assert os.path.exists(tmp_path / "datacontract.html") + + +def test_schemas_are_rendered(): + """Regression test for #880: schemas should render in the ODCS HTML template.""" + runner = CliRunner() + result = runner.invoke(app, ["export", "./fixtures/export/datacontract.odcs.yaml", "--format", "html"]) + assert result.exit_code == 0 + # The schema name 'orders' and a property name 'order_id' should appear in the output + assert "orders" in result.output + assert "order_id" in result.output From b402287a71742658325699c92a4330cd77553751 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakob=20Sch=C3=B6dl?= Date: Thu, 2 Apr 2026 16:31:39 +0200 Subject: [PATCH 2/2] remove changelog entry --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index efd50dfea..226136498 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fix SQL export generating multiple PRIMARY KEY constraints for composite keys (#1026) - Preserve parametrized physicalTypes for SQL export (#1086) - Fix incorrect SQL type mappings: SQL Server `double`/`jsonb`, MySQL bare `varchar`, missing Trino types (#1110) -- Fix ODCS HTML export not rendering schemas due to wrong attribute name (`schema` vs `schema_`) (#880) ## [0.11.7] - 2026-03-24