Skip to content

Commit 233359a

Browse files
authored
353 the script incorrectly detects vpc and port channel interfaces as cscwh68103 invalid fabricpathep targets (#357)
* specific testing for known failure conditions of cscwh68103 as to not catch valid scenarios
1 parent 04fef19 commit 233359a

2 files changed

Lines changed: 16 additions & 1 deletion

File tree

aci-preupgrade-validation-script.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4738,6 +4738,7 @@ def fabricPathEp_target_check(**kwargs):
47384738
fex_a = groups.get("fexA")
47394739
fex_b = groups.get("fexB")
47404740
path = groups.get("path")
4741+
print(path)
47414742

47424743
# CHECK FEX ID(s) of extpath(s) is 101 or greater
47434744
if fex_a:
@@ -4772,7 +4773,13 @@ def fabricPathEp_target_check(**kwargs):
47724773
elif int(third) > 16:
47734774
data.append([dn, "eth port {} is invalid (1-16 expected) for breakout ports".format(third)])
47744775
else:
4775-
data.append([dn, "PathEp 'eth' syntax is invalid"])
4776+
# CHECK eth1//0 malform scenario (double slashes)
4777+
if "//" in path:
4778+
data.append([dn, "PathEp 'eth' syntax is invalid"])
4779+
# CHECK Ethx/y malform scenario (should not be caps)
4780+
elif path.startswith("Eth"):
4781+
data.append([dn, "PathEp 'eth' should be lowercase 'eth'"])
4782+
47764783
else:
47774784
data.append([dn, "target is not a valid fabricPathEp DN"])
47784785

tests/checks/fabricPathEP_target_check/infraRsHPathAtt_neg.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,13 @@
1414
"tDn": "topology/pod-1/paths-101/pathep-[eth1/1]"
1515
}
1616
}
17+
}, {
18+
"infraRsHPathAtt": {
19+
"attributes": {
20+
"dn": "uni/infra/hpaths-__ui_xxx_201-202_Eth49-50/rsHPathAtt-[topology/pod-1/paths-201/pathep-[xxx_201-202_Eth49-50]]",
21+
"tCl": "fabricPathEp",
22+
"tDn": "topology/pod-1/paths-201/pathep-[xxx_201-202_Eth49-50]"
23+
}
24+
}
1725
}
1826
]

0 commit comments

Comments
 (0)