fix(contracts): accept ODCS v3.1.0 transformSourceObjects array#323
Open
SAY-5 wants to merge 1 commit into
Open
fix(contracts): accept ODCS v3.1.0 transformSourceObjects array#323SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
larsgeorge-db
force-pushed
the
fix/odcs-transform-source-objects-list
branch
from
e0727c8 to
32eb5b9
Compare
ColumnProperty.transformSourceObjects was typed as Optional[str], so ODCS v3.1.0-compliant uploads using the spec's array form (e.g. ["tbl_a"]) hit HTTP 422 at POST /api/data-contracts even though they passed the JSON-schema validator. Widen the type to Union[List[str], str] so the spec-compliant list form is accepted while existing string inputs remain valid; persistence and export already handle both shapes. Fixes databrickslabs#285. Signed-off-by: SAY-5 <say.apm35@gmail.com>
larsgeorge-db
force-pushed
the
fix/odcs-transform-source-objects-list
branch
from
7e847c9 to
51c9457
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #285.
ColumnProperty.transformSourceObjectswas typed asOptional[str], so ODCS v3.1.0-compliant uploads using the spec's array form (e.g.["tbl_a"]) failed atPOST /api/data-contractswith HTTP 422 ("Input should be a valid string") even though they passed the GitHub-workflow JSON-schema validation. Widening the type toUnion[List[str], str]matches the ODCS v3.1.0SchemaBasePropertydefinition while keeping legacy string inputs valid; persistence (data_contracts_manager.py:1766) and export (:999) already handle both shapes.