function name should be included in the error message when not bound in call

[He-Pin]

In #39, @eregon report:

#39 (comment)

I think he is right here, and I think the function name should be included in the error message, eg:

    test("unboundParam") {
      val ex = intercept[Exception] {
        eval(
          """local newParams(x, y) = {
            |  x: x,
            |  y: y,
            |};
            |
            |local params = newParams("a");
            |
            |params.y
            |
        """.stripMargin,
          useNewEvaluator = useNewEvaluator
        )
      }

      assert(ex.getMessage.contains("Function parameter y not bound in call"))
    }

can be Function parameter y not bound in call to function newParams

[eregon]

That would be helpful, but also mentioning not enough/too many arguments would be the clearest I believe.
Because "parameter y not bound" sounds very vague at least to me, like some variable hasn't a value yet because lazy semantics or something.
In general I would say this error is not about binding of variables, it's about not enough/too many arguments.

For example this is what Ruby does in such a case:

$ ruby -e 'def m(a,b) = 0; m(1)'       
-e:1:in `m': wrong number of arguments (given 1, expected 2) (ArgumentError)

It's very clear, compared to "parameter b not bound in call".

[He-Pin]

@eregon Nice, would you like to contribute this a PR?

[stephenamar-db]

It's really tricky to get the function name here because there are just so many ways to define functions, and not all of them have clear name:

local f(arg) =...
local f = function(arg) ...

Then you can also define functions as a value in an object - that's actually fairly common. What name do you give it?

[He-Pin]

That's true, we can only give it our best effort, is there any eta of sjsonnet 1.0.0 ?