Wire comparator CI to call run-comparator.sh and attach files to email#1463
Open
sreekanth-db wants to merge 5 commits into
Open
Wire comparator CI to call run-comparator.sh and attach files to email#1463sreekanth-db wants to merge 5 commits into
sreekanth-db wants to merge 5 commits into
Conversation
Co-authored-by: Isaac Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
Restrictive defaults (DATABASE_METADATA / getCatalogs / DEFAULT_PARAMS) would silently scope down every manual run, diverging from cron behavior. Empty defaults align manual dispatch with the weekly schedule; users can still type restrictive values into the dispatch form when they want a quick run. Co-authored-by: Isaac Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
CI runners have no global git user.name/user.email, so the `git merge --no-ff` step inside the script fails with "empty ident name not allowed". --local scope keeps this confined to the temp clone; caller's global config is untouched. Co-authored-by: Isaac Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
`ref: comparator-v2` was hardcoded, so a workflow_dispatch on any PR branch would still pull the script from comparator-v2 (the stale base copy), bypassing changes under review. Using `github.ref` resolves to the PR branch for PR dispatches and to comparator-v2 for base-branch dispatches. Co-authored-by: Isaac Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
If this workflow ever moves to main to enable cron, schedule events fire with github.ref=refs/heads/main, which would checkout main and miss the comparator framework. The conditional ensures cron always tests comparator-v2 while preserving PR-branch testing via dispatch. Co-authored-by: Isaac Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mvninvocation withrun-comparator.sh, so CI and local dev share one execution path.run-comparator.shto read all config from env vars (with v6-derived defaults baked in:getFunctionsskip, threads=50, fullFILTER_JSONwith documented exclusions), validate required env, and exit with mvn's actual status.bin/format-comparator-email.sh) to plain-text + attachments (report TXT + CSV + log).workflow_dispatchinputs (suites,metadata_methods,connection_config) with restrictive defaults for fast manual testing; weekly cron is unaffected.~/.m2/settings.xmlconfiguration block from main's workflow.Test plan
actionlintcleanactsucceeds end-to-end (checkout → setup-java → fake comparator → locate-files → skip-email-under-act → artifact zip with all 3 files)workflow_dispatchon this branch with restricted defaults +EMAIL_RECIPIENTSset to meNO_CHANGELOG=true
This pull request and its description were written by Isaac.