Fix double backtick wrapping in setCatalog and setSchema#1454
Open
no23reason wants to merge 2 commits into
Open
Fix double backtick wrapping in setCatalog and setSchema#1454no23reason wants to merge 2 commits into
no23reason wants to merge 2 commits into
Conversation
When catalog or schema names were passed already wrapped in backticks, setCatalog/setSchema would produce invalid SQL like SET CATALOG ``name``. Strip existing backticks before wrapping and before storing, so getCatalog/ getSchema always return the bare identifier name. Fixes databricks#1453 Signed-off-by: Dan Homola <dan.homola@hotmail.cz>
no23reason
force-pushed
the
double-backticks
branch
from
ec2736d to
9252daf
Compare
gopalldb
approved these changes
May 21, 2026
Collaborator
gopalldb
left a comment
gopalldb
left a comment
There was a problem hiding this comment.
Thanks for contributing!
Author
|
Thanks for the review! I resolved the conflicts by merge, I hope that is ok. Or should I rebase instead? |
msrathore-db
approved these changes
May 22, 2026
Collaborator
msrathore-db
left a comment
msrathore-db
left a comment
There was a problem hiding this comment.
Thanks for the change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When catalog or schema names were passed already wrapped in backticks, setCatalog/setSchema would produce invalid SQL like
Strip existing backticks before wrapping and before storing, so getCatalog/ getSchema always return the bare identifier name.
Testing
The changes are covered by unit tests.
Additional Notes to the Reviewer
This fixes #1453 and restores compatibility with v2 of the jdbc driver: it also allowed "pre-quoted" identifiers and handled them correctly.