From 1f5304b1a5b867f857a66b39151aa1f118973586 Mon Sep 17 00:00:00 2001 From: Chris Stephens Date: Fri, 12 Jun 2026 12:33:58 -0700 Subject: [PATCH] acc: Shrink lifecycle-started warehouse tests to 2X-Small with 10min auto-stop The lifecycle-started SQL warehouse acceptance tests created Medium classic warehouses (n2-highmem-8 nodes with local SSD on GCP) with the default 120 minute auto-stop, and lifecycle.started: true actively started them on deploy. Leaked warehouses from these tests exhausted the LOCAL_SSD_TOTAL_GB_PER_VM_FAMILY quota (30TB) in the shared GCP test project, taking down all terraform provider CI. Shrink every cloud-running acceptance test that creates a classic warehouse to 2X-Small (roughly 8x smaller than Medium) and set auto_stop_mins: 10 (the classic-warehouse minimum) so any leaked warehouse stops itself quickly: - bundle/resources/sql_warehouses/lifecycle-started* - bundle/invariant/configs/sql_warehouse.yml.tmpl (was X-Small, no auto-stop) - bundle/resources/permissions/factcheck (was Small, no auto-stop) - bundle/config-remote-sync/multiple_resources (already 2X-Small, no auto-stop) Serverless warehouse configs (enable_serverless_compute: true) are left unchanged since they consume no GCE quota, as are testserver-only tests. Co-authored-by: Isaac --- .../config-remote-sync/multiple_resources/databricks.yml.tmpl | 1 + acceptance/bundle/invariant/configs/sql_warehouse.yml.tmpl | 3 ++- .../resources/permissions/factcheck/databricks.yml.tmpl | 3 ++- .../lifecycle-started-toggle/databricks.yml.tmpl | 3 ++- .../sql_warehouses/lifecycle-started-toggle/output.txt | 4 ++-- .../sql_warehouses/lifecycle-started/databricks.yml.tmpl | 3 ++- .../resources/sql_warehouses/lifecycle-started/output.txt | 4 ++-- 7 files changed, 13 insertions(+), 8 deletions(-) diff --git a/acceptance/bundle/config-remote-sync/multiple_resources/databricks.yml.tmpl b/acceptance/bundle/config-remote-sync/multiple_resources/databricks.yml.tmpl index 421e62dc152..1cc53611e12 100644 --- a/acceptance/bundle/config-remote-sync/multiple_resources/databricks.yml.tmpl +++ b/acceptance/bundle/config-remote-sync/multiple_resources/databricks.yml.tmpl @@ -53,6 +53,7 @@ resources: test_warehouse: name: warehouse-$UNIQUE_NAME cluster_size: 2X-Small + auto_stop_mins: 10 targets: default: diff --git a/acceptance/bundle/invariant/configs/sql_warehouse.yml.tmpl b/acceptance/bundle/invariant/configs/sql_warehouse.yml.tmpl index 4c1bef63037..f239f85afed 100644 --- a/acceptance/bundle/invariant/configs/sql_warehouse.yml.tmpl +++ b/acceptance/bundle/invariant/configs/sql_warehouse.yml.tmpl @@ -5,7 +5,8 @@ resources: sql_warehouses: foo: name: test-warehouse-$UNIQUE_NAME - cluster_size: X-Small + cluster_size: 2X-Small + auto_stop_mins: 10 max_num_clusters: 1 min_num_clusters: 1 warehouse_type: CLASSIC diff --git a/acceptance/bundle/resources/permissions/factcheck/databricks.yml.tmpl b/acceptance/bundle/resources/permissions/factcheck/databricks.yml.tmpl index e049be4cb13..397f257a332 100644 --- a/acceptance/bundle/resources/permissions/factcheck/databricks.yml.tmpl +++ b/acceptance/bundle/resources/permissions/factcheck/databricks.yml.tmpl @@ -19,4 +19,5 @@ resources: sql_warehouses: warehouse: name: foo_$UNIQUE_NAME - cluster_size: Small + cluster_size: 2X-Small + auto_stop_mins: 10 diff --git a/acceptance/bundle/resources/sql_warehouses/lifecycle-started-toggle/databricks.yml.tmpl b/acceptance/bundle/resources/sql_warehouses/lifecycle-started-toggle/databricks.yml.tmpl index b13f77d0af5..a00485190ff 100644 --- a/acceptance/bundle/resources/sql_warehouses/lifecycle-started-toggle/databricks.yml.tmpl +++ b/acceptance/bundle/resources/sql_warehouses/lifecycle-started-toggle/databricks.yml.tmpl @@ -8,6 +8,7 @@ resources: sql_warehouses: mywarehouse: name: $UNIQUE_NAME - cluster_size: "Medium" + cluster_size: "2X-Small" + auto_stop_mins: 10 lifecycle: started: false diff --git a/acceptance/bundle/resources/sql_warehouses/lifecycle-started-toggle/output.txt b/acceptance/bundle/resources/sql_warehouses/lifecycle-started-toggle/output.txt index b6fa122cc08..002a36777dd 100644 --- a/acceptance/bundle/resources/sql_warehouses/lifecycle-started-toggle/output.txt +++ b/acceptance/bundle/resources/sql_warehouses/lifecycle-started-toggle/output.txt @@ -11,8 +11,8 @@ Deployment complete! "method": "POST", "path": "/api/2.0/sql/warehouses", "body": { - "auto_stop_mins": 120, - "cluster_size": "Medium", + "auto_stop_mins": 10, + "cluster_size": "2X-Small", "enable_photon": true, "max_num_clusters": 1, "name": "[UNIQUE_NAME]", diff --git a/acceptance/bundle/resources/sql_warehouses/lifecycle-started/databricks.yml.tmpl b/acceptance/bundle/resources/sql_warehouses/lifecycle-started/databricks.yml.tmpl index 6eb3ba981e2..cfcc45c621f 100644 --- a/acceptance/bundle/resources/sql_warehouses/lifecycle-started/databricks.yml.tmpl +++ b/acceptance/bundle/resources/sql_warehouses/lifecycle-started/databricks.yml.tmpl @@ -8,6 +8,7 @@ resources: sql_warehouses: mywarehouse: name: $UNIQUE_NAME - cluster_size: "Medium" + cluster_size: "2X-Small" + auto_stop_mins: 10 lifecycle: started: true diff --git a/acceptance/bundle/resources/sql_warehouses/lifecycle-started/output.txt b/acceptance/bundle/resources/sql_warehouses/lifecycle-started/output.txt index 027d148fdf8..21c9214f16b 100644 --- a/acceptance/bundle/resources/sql_warehouses/lifecycle-started/output.txt +++ b/acceptance/bundle/resources/sql_warehouses/lifecycle-started/output.txt @@ -11,8 +11,8 @@ Deployment complete! "method": "POST", "path": "/api/2.0/sql/warehouses", "body": { - "auto_stop_mins": 120, - "cluster_size": "Medium", + "auto_stop_mins": 10, + "cluster_size": "2X-Small", "enable_photon": true, "max_num_clusters": 1, "name": "[UNIQUE_NAME]",