Remove unnecessary postinit function execution

Author: pkosiec

libs/apps/initializer/nodejs.go

@@ -40,9 +40,6 @@ func (i *InitializerNodeJs) Initialize(ctx context.Context, workDir string) *Ini
 		}
 	}
 
-	// Step 3: Run postinit script if defined (fully optional — errors are logged, not fatal)
-	i.runNpmPostInit(ctx, workDir)
-
 	return &InitResult{
 		Success: true,
 		Message: "Node.js project initialized successfully",
@@ -105,43 +102,6 @@ func (i *InitializerNodeJs) runAppkitSetup(ctx context.Context, workDir string)
 	})
 }
 
-// runNpmPostInit runs "npm run postinit" if the script is defined in package.json.
-// Failures are logged as warnings and never propagate — postinit is fully optional.
-func (i *InitializerNodeJs) runNpmPostInit(ctx context.Context, workDir string) {
-	if !i.hasNpmScript(workDir, "postinit") {
-		return
-	}
-	err := prompt.RunWithSpinnerCtx(ctx, "Running post-init...", func() error {
-		cmd := exec.CommandContext(ctx, "npm", "run", "postinit")
-		cmd.Dir = workDir
-		cmd.Stdout = nil
-		cmd.Stderr = nil
-		return cmd.Run()
-	})
-	if err != nil {
-		log.Debugf(ctx, "postinit script failed (non-fatal): %v", err)
-	}
-}
-
-// hasNpmScript reports whether the given script name is defined in the project's package.json.
-func (i *InitializerNodeJs) hasNpmScript(workDir, script string) bool {
-	packageJSONPath := filepath.Join(workDir, "package.json")
-	data, err := os.ReadFile(packageJSONPath)
-	if err != nil {
-		return false
-	}
-
-	var pkg struct {
-		Scripts map[string]string `json:"scripts"`
-	}
-	if err := json.Unmarshal(data, &pkg); err != nil {
-		return false
-	}
-
-	_, ok := pkg.Scripts[script]
-	return ok
-}
-
 // hasAppkit checks if the project has @databricks/appkit in its dependencies.
 func (i *InitializerNodeJs) hasAppkit(workDir string) bool {
 	packageJSONPath := filepath.Join(workDir, "package.json")

libs/apps/initializer/nodejs_test.go

@@ -65,60 +65,3 @@ func TestHasAppkitNoPackageJSON(t *testing.T) {
 	init := &InitializerNodeJs{}
 	assert.False(t, init.hasAppkit(tmpDir))
 }
-
-func TestHasNpmScript(t *testing.T) {
-	tests := []struct {
-		name        string
-		packageJSON string
-		script      string
-		want        bool
-	}{
-		{
-			name:        "script present",
-			packageJSON: `{"scripts": {"postinit": "appkit postinit"}}`,
-			script:      "postinit",
-			want:        true,
-		},
-		{
-			name:        "script absent",
-			packageJSON: `{"scripts": {"build": "tsc"}}`,
-			script:      "postinit",
-			want:        false,
-		},
-		{
-			name:        "no scripts section",
-			packageJSON: `{}`,
-			script:      "postinit",
-			want:        false,
-		},
-		{
-			name:        "invalid json",
-			packageJSON: `not json`,
-			script:      "postinit",
-			want:        false,
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			tmpDir, err := os.MkdirTemp("", "nodejs-test-*")
-			require.NoError(t, err)
-			defer os.RemoveAll(tmpDir)
-
-			err = os.WriteFile(filepath.Join(tmpDir, "package.json"), []byte(tt.packageJSON), 0o644)
-			require.NoError(t, err)
-
-			i := &InitializerNodeJs{}
-			assert.Equal(t, tt.want, i.hasNpmScript(tmpDir, tt.script))
-		})
-	}
-}
-
-func TestHasNpmScriptNoPackageJSON(t *testing.T) {
-	tmpDir, err := os.MkdirTemp("", "nodejs-test-*")
-	require.NoError(t, err)
-	defer os.RemoveAll(tmpDir)
-
-	i := &InitializerNodeJs{}
-	assert.False(t, i.hasNpmScript(tmpDir, "postinit"))
-}