Skip to content

Commit 3b00ad6

Browse files
authored
chore: setup import ordering with Biome (#77)
* chore: setup import ordering with Biome - Enable organizeImports assist action in biome.json - Update lint-staged to use `biome check --write` for combined linting, formatting, and import sorting on pre-commit - Update CI to use `pnpm check` instead of separate lint/format commands Signed-off-by: Jorge Calvar <jorge.calvar@databricks.com> * chore: apply import ordering to docs - Add docs:check and docs:check:fix commands for combined lint/format/import sorting - Keep docs:format and docs:lint commands (without --write) for checking only - Restore root format, format:check, lint, lint:fix commands - Update CI to use docs:check:fix for generated docs Signed-off-by: Jorge Calvar <jorge.calvar@databricks.com> --------- Signed-off-by: Jorge Calvar <jorge.calvar@databricks.com>
1 parent e4458d1 commit 3b00ad6

55 files changed

Lines changed: 116 additions & 120 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/ci.yml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,8 @@ jobs:
5050
cache: 'pnpm'
5151
- name: Install dependencies
5252
run: pnpm install --frozen-lockfile
53-
- name: Run Lint
54-
run: pnpm run lint
55-
- name: Run Format Check
56-
run: pnpm run format:check
53+
- name: Run Biome Check
54+
run: pnpm run check
5755
- name: Run Types Check
5856
run: pnpm run typecheck
5957
- name: Run License Check
@@ -98,10 +96,8 @@ jobs:
9896
run: pnpm install --frozen-lockfile
9997
- name: Build Docs
10098
run: pnpm run docs:build
101-
- name: Lint Generated Docs
102-
run: pnpm run docs:lint
103-
- name: Format Generated Docs
104-
run: pnpm run docs:format
99+
- name: Check Generated Docs
100+
run: pnpm run docs:check
105101
- name: Check for uncommitted docs changes
106102
run: |
107103
if ! git diff --exit-code docs/docs/api/; then
@@ -112,7 +108,7 @@ jobs:
112108
echo ""
113109
echo "To fix this:"
114110
echo " 1. Run: pnpm docs:build"
115-
echo " 2. Run: pnpm docs:format"
111+
echo " 2. Run: pnpm docs:check:fix"
116112
echo " 3. Review and commit the changes"
117113
echo ""
118114
exit 1

apps/clean-app/eslint.config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import js from "@eslint/js";
2-
import globals from "globals";
2+
import { defineConfig, globalIgnores } from "eslint/config";
33
import reactHooks from "eslint-plugin-react-hooks";
44
import reactRefresh from "eslint-plugin-react-refresh";
5+
import globals from "globals";
56
import tseslint from "typescript-eslint";
6-
import { defineConfig, globalIgnores } from "eslint/config";
77

88
export default defineConfig([
99
globalIgnores(["dist"]),

apps/clean-app/vite.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { defineConfig } from "vite";
21
import react from "@vitejs/plugin-react";
2+
import { defineConfig } from "vite";
33

44
// https://vite.dev/config/
55
export default defineConfig({

apps/dev-playground/client/src/components/analytics/filter-bar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import type { Aggregation, DashboardFilters } from "@/lib/types";
21
import {
32
Card,
43
CardContent,
@@ -8,6 +7,7 @@ import {
87
SelectTrigger,
98
SelectValue,
109
} from "@databricks/appkit-ui/react";
10+
import type { Aggregation, DashboardFilters } from "@/lib/types";
1111

1212
interface FilterBarProps {
1313
filters: DashboardFilters;

apps/dev-playground/client/src/components/analytics/untagged-apps-table.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
import { AppsDataTable } from "@/components/apps-data-table";
21
import {
32
Card,
43
CardContent,
54
CardDescription,
65
CardHeader,
76
CardTitle,
87
} from "@databricks/appkit-ui/react";
8+
import { AppsDataTable } from "@/components/apps-data-table";
99

1010
interface UntaggedApp {
1111
id: string;

apps/dev-playground/client/src/components/analytics/usage-trends-chart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { sql } from "@databricks/appkit-ui/js";
2-
import { BarChart } from "@databricks/appkit-ui/react";
32
import {
3+
BarChart,
44
Card,
55
CardContent,
66
CardHeader,

apps/dev-playground/client/src/components/error-component.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
import { type ErrorComponentProps, Link } from "@tanstack/react-router";
21
import {
32
Button,
43
Card,
54
CardContent,
65
CardHeader,
76
CardTitle,
87
} from "@databricks/appkit-ui/react";
8+
import { type ErrorComponentProps, Link } from "@tanstack/react-router";
99

1010
export function ErrorComponent({ error }: { error: ErrorComponentProps }) {
1111
return (

apps/dev-playground/client/src/components/layout/header.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
import { InfoIcon } from "lucide-react";
21
import {
32
Tooltip,
43
TooltipContent,
54
TooltipTrigger,
65
} from "@databricks/appkit-ui/react";
6+
import { InfoIcon } from "lucide-react";
77

88
export function Header({
99
title,

apps/dev-playground/client/src/components/reconnect/page-header.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
import { InfoIcon } from "lucide-react";
21
import {
32
Tooltip,
43
TooltipContent,
54
TooltipTrigger,
65
} from "@databricks/appkit-ui/react";
6+
import { InfoIcon } from "lucide-react";
77

88
export function PageHeader() {
99
return (

apps/dev-playground/client/src/components/theme-selector.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
import { useEffect, useState } from "react";
2-
import { MoonIcon, SunIcon, MonitorIcon } from "lucide-react";
31
import {
2+
Button,
43
DropdownMenu,
54
DropdownMenuContent,
65
DropdownMenuItem,
76
DropdownMenuTrigger,
87
} from "@databricks/appkit-ui/react";
9-
import { Button } from "@databricks/appkit-ui/react";
8+
import { MonitorIcon, MoonIcon, SunIcon } from "lucide-react";
9+
import { useEffect, useState } from "react";
1010

1111
type Theme = "light" | "dark" | "system";
1212

0 commit comments

Comments
 (0)