Skip to content

Conversation

@Markzipan
Copy link
Contributor

@Markzipan Markzipan commented Dec 4, 2025

Adds support for DDC's new module system, which supports hot reload.

This is currently locked behind the canary flag in webdev and requires uses-hot-reload flags to be enabled on downstream builders.

Notable update:

  • Adds the requisite options to downstream builders when --canary is passed to webdev.
  build_web_compilers|sdk_js:
    options:
      web-hot-reload: true
  build_web_compilers|entrypoint:
    options:
      web-hot-reload: true
  build_web_compilers|entrypoint_marker:
    options:
      web-hot-reload: true
  build_web_compilers|ddc:
    options:
      web-hot-reload: true
  build_web_compilers|ddc_modules:
    options:
      web-hot-reload: true
  • Always requests changed assets from build_daemon
  • Adds a special handler at $ROOT/reloaded_sources.json that serves reloaded sources

@Markzipan Markzipan requested a review from davidmorgan December 4, 2025 06:07
@Markzipan Markzipan marked this pull request as ready for review December 4, 2025 06:07
@Markzipan Markzipan requested a review from bkonyi December 4, 2025 06:08
Copy link
Contributor

@davidmorgan davidmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! CI didn't run due to path overrides, please check it's green before merging.

Copy link
Collaborator

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@davidmorgan davidmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM :) thanks.

@Markzipan Markzipan merged commit e2d14f1 into dart-lang:main Dec 5, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants