fixed linting - debugExtension

Author: jyameo

dwds/analysis_options.yaml

@@ -6,7 +6,3 @@ analyzer:
     - "lib/data/*"
     # Ignore debug extension builds
     - "debug_extension/compiled/*"
-
-linter:
-  rules:
-    - always_use_package_imports

dwds/debug_extension/web/chrome_api.dart

@@ -403,7 +403,10 @@ class NavigationInfo {
 @JS()
 @anonymous
 class Windows {
-  external dynamic create(WindowInfo? createData, Function(WindowObj) callback);
+  external dynamic create(
+    WindowInfo? createData,
+    void Function(WindowObj) callback,
+  );
 
   external OnFocusChangedHandler get onFocusChanged;
 }

dwds/debug_extension/web/cider_connection.dart

@@ -100,8 +100,8 @@ void _sendMessageToCider(String json) {
 }
 
 Future<void> _handleMessageFromCider(dynamic message, Port _) async {
-  final key = getProperty(message as Object, 'key');
-  final json = getProperty(message, 'json');
+  final key = getProperty<String?>(message as Object, 'key');
+  final json = getProperty<String?>(message, 'json');
   if (key != _ciderDartMessageKey || json is! String) {
     sendErrorMessageToCider(
       errorType: CiderErrorType.invalidRequest,

dwds/debug_extension/web/cross_extension_communication.dart

@@ -76,7 +76,7 @@ void _forwardCommandToChromeDebugger(
       options.method,
       options.commandParams,
       allowInterop(
-        ([result]) => _respondWithChromeResult(result, sendResponse),
+        ([Object? result]) => _respondWithChromeResult(result, sendResponse),
       ),
     );
   } catch (e) {
@@ -110,7 +110,7 @@ void _forwardMessageToAngularDartDevTools(ExternalExtensionMessage message) {
     message,
     // options
     null,
-    allowInterop(([result]) => _checkForErrors(result, message.name)),
+    allowInterop(([Object? result]) => _checkForErrors(result, message.name)),
   );
 }
 

dwds/debug_extension/web/debug_session.dart

@@ -449,7 +449,7 @@ void _forwardDwdsEventToChromeDebugger(
       Debuggee(tabId: tabId),
       message.command,
       js_util.jsify(params),
-      allowInterop(([e]) {
+      allowInterop(([Object? e]) {
         // No arguments indicate that an error occurred.
         if (e == null) {
           client.sink.add(

dwds/debug_extension/web/detector.dart

@@ -99,10 +99,11 @@ void _detectMultipleDartAppsCallback(
 bool _isMultipleAppsMutation(dynamic mutation) {
   final isAttributeMutation =
       hasProperty(mutation as Object, 'type') &&
-      getProperty(mutation, 'type') == 'attributes';
+      getProperty<String?>(mutation, 'type') == 'attributes';
   if (isAttributeMutation) {
     return hasProperty(mutation, 'attributeName') &&
-        getProperty(mutation, 'attributeName') == _multipleAppsAttribute;
+        getProperty<String?>(mutation, 'attributeName') ==
+            _multipleAppsAttribute;
   }
   return false;
 }

dwds/debug_extension/web/storage.dart

@@ -151,7 +151,7 @@ void interceptStorageChange<T>({
     final isExpected = hasProperty(storageObj, expectedStorageKey);
     if (!isExpected) return;
 
-    final objProp = getProperty(storageObj, expectedStorageKey);
+    final objProp = getProperty<Object?>(storageObj, expectedStorageKey);
     final json = getProperty(objProp as Object, 'newValue') as String?;
     T? decodedObj;
     if (json == null || T == String) {

dwds/debug_extension/web/utils.dart

@@ -124,7 +124,7 @@ final bool isDevMode = () {
 final bool isMV3 = () {
   final extensionManifest = chrome.runtime.getManifest();
   final manifestVersion =
-      getProperty(extensionManifest, 'manifest_version') ?? 2;
+      getProperty<int?>(extensionManifest, 'manifest_version') ?? 2;
   return manifestVersion == 3;
 }();
 

dwds/debug_extension/web/web_api.dart

@@ -32,11 +32,11 @@ external Object _nativeJsFetch(String resourceUrl, FetchOptions options);
 Future<FetchResponse> fetchRequest(String resourceUrl) async {
   try {
     final options = FetchOptions(method: 'GET', credentials: 'include');
-    final response = await promiseToFuture(
+    final response = await promiseToFuture<Object>(
       _nativeJsFetch(resourceUrl, options),
     );
     final body = await promiseToFuture<String?>(
-      js_util.callMethod(response as Object, 'text', []),
+      js_util.callMethod(response, 'text', []),
     );
     final ok = js_util.getProperty<bool>(response, 'ok');
     final status = js_util.getProperty<int>(response, 'status');