Commit b566ba1
[cfe] Run incremental macro tests in separate incremental compilers
The way constants are printed using ast-to-text depend on which
libraries are available in the component. Because the incremental
compiler (by default) only returns the libraries that have been
recompiled, the first compilation contains more libraries than the
subsequent compilations. Using the same incremental compiler throughout
the incremental macro test made the output depend on the order in which
the tests were run, which in turn was dependent on the file order in
the directory.
To avoid this, and to support running individual tests with a stable
output, each test is now using its own increment compiler for all the
incremental steps within the test.
Closes #48558
Change-Id: I37946ed0f940b6644c5efb2b7d167b2a5717f2f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240721
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>1 parent a17bd9e commit b566ba1
File tree
4 files changed
+4
-4
lines changed- pkg/front_end/test/macros/incremental
- data/tests
- user_macro
4 files changed
+4
-4
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
105 | | - | |
106 | 105 | | |
107 | 106 | | |
108 | 107 | | |
109 | 108 | | |
110 | 109 | | |
| 110 | + | |
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
| |||
0 commit comments