feat(FLU): Show trade data for all moors.dll stuff

[dd84ai]

detect moors.dll, and same as disco show extra trade calculations based on graph of calculations for ships having ability to dock only breth/moor_medium or medium_large only accordingly

P.S. will be useful for future FLU version

[dd84ai]

Caenen — 11:04 PM
Feature request that users and devs of modded servers like discovery and FL:SR might find particularly handy:
-> In each tab giving trade routes, let the player filter by size of the dock or mooring:
Berth for small ships (or a different word since that might be a difficult volcabulary for non-english people)
medium mooring point
large mooring point
For vanilla this does not matter, of course, since you can never fly ships that dock by mooring, and i think you even need a slight modification to the game somewhere to even allow it to work. Plenty other mods make capital ships flyable, however
Should I make an issue for this?
Darkwind The Dark Duck — 11:06 PM
issue to create is good.
i need extra info on this topic
Caenen — 11:07 PM
Would that be a duplicate of this one? #162
GitHub
feat(FLU): Show trade data for all moors.dll stuff · Issue #162 ·...
detect moors.dll, and same as disco show extra trade calculations based on graph of calculations for ships having ability to dock only breth/moor_medium or medium_large only accordingly P.S. will b...
feat(FLU): Show trade data for all moors.dll stuff · Issue #162 ·...
Darkwind The Dark Duck — 11:08 PM
sounds like related
can u clarify berth/medium/large, which ship classes can dock what?
Caenen — 11:09 PM
As in, how you read it out of the game?
Darkwind The Dark Duck — 11:09 PM
type DockableOptions struct {
IsDisco bool // disco allows for transports jump

PlayersCanDockBerth      bool
PlayersCanDockMoorMedium bool
PlayersCanDockMoorLarge  bool

}

type DockableResult struct {
IsDockable bool
IsDockableByTransports bool // important distinguishing for disco. only jump and moor_large valid khm?
}

func (solar *Solar) IsDockable(options DockableOptions) DockableResult {
var result DockableResult
for _, docking_sphere := range solar.DockingSpheres {
if docking_sphere_name, dockable := docking_sphere.GetValue(); dockable {
if docking_sphere_name == DockingSphereJump {
result.IsDockableByTransports = true
result.IsDockable = true
}
if docking_sphere_name == DockingSphereRing {
result.IsDockable = true
}
if options.PlayersCanDockBerth && docking_sphere_name == DockingSphereBerth {
result.IsDockable = true
}
if options.PlayersCanDockMoorMedium && docking_sphere_name == DockingSphereMoorMedium {
result.IsDockable = true
}
if options.PlayersCanDockMoorLarge && docking_sphere_name == DockingSphereMoorLarge {
result.IsDockable = true
}

        if options.IsDisco {
            if docking_sphere_name == DockingSphereMoorMedium {
                result.IsDockableByTransports = true
            }
        } else {
            result.IsDockableByTransports = result.IsDockable
        }
    }
}
return result

}

and preferably comparison to disco if possible.
Disco has next docking rules
Darkwind The Dark Duck — 11:10 PM
as in.. in Disco for example Transports(and Capital ships like Battleships) can dock Medium Mooring point
Large is not idea for what, but supposedly dockable by fighters
All three types Berth, Medium and Large are dockable by fighters
also DockingSphereJump is dockable by transports and fighters
and DockingSphereRing is dockable only by fighters but not by transports
how it is different for FLSR?
Berth: ...fill..
MediumMooring
LargeMooring
DockingSphereRing
DockingSphereJump
anything else i should be aware?
Caenen — 11:14 PM
Any fighter, freighter and (unlike in vanilla) the Repairship and Armored Transport use berths. Cannot dock with any other type, same with the other two cases below.

Gunboats, Cruisers, Lifters, and Transports and Trains of all sizes use medium moors

Battleships, Liners and Asteroid Miners use large moors.

Docking sphere ring can be treated like berth, afaik. Jump points can be docked by all 3.
I think that is defined in the ship archetype directly though
and you shouldn't need to parse the specific ship, unless you really want to
Darkwind The Dark Duck — 11:15 PM
ok. sounds like all three docking choices i have to show for FLSR to make it right
i have already system in place i can adapt for it
Caenen — 11:16 PM
Hence me suggesting some sort of filter of up-to-3 keywords to include (and show all otherwise)
Darkwind The Dark Duck — 11:16 PM
do they still have all same normal max speed 350? (all three ship categories)
Caenen — 11:16 PM
Yeah I suspected, since I can see "time to moor" in the travel time calculation
Darkwind The Dark Duck — 11:16 PM
ok. i can adapt existing code to that rather simply i think somehow
Caenen — 11:17 PM
To add; all 5 tabs "1-way routes", "2-way routes", "Trade from", "Trade to" and "Travel Routes" should probably use this
I suspect FL:SR is identical or nearly-identical in implementation with discovery, overall
Darkwind The Dark Duck — 11:19 PM
discovery has in the end three categories of ships too. so it is very convinient match for code reusage 🙂 of how to show it all
Caenen — 11:19 PM
but I dont know how Discovery designs the game around the vanilla docking types. I think they also assign "large moor" and "medium moor" to the same mooring point (maybe even berth as well), which is something you can do to allow both classes of ships to use the same point, but in the background they're still using the same Vanilla stuff like we do
Caenen — 11:20 PM
It's not a convenient match moreso than it is the way Freelancer works and it's probably not easy to change

[Caenen]

Bumping this Feature Request on the behalf of FL:SR also.

I suggest some sort of filter of up-to-3 keywords to include (and show all otherwise) in each tab giving trade routes. Let the player filter by size of the dock or mooring:

• Berth for small ships (or a different word since that might be a difficult volcabulary for non-english people)
• medium mooring point
• large mooring point

All 5 travel-related tabs "1-way routes", "2-way routes", "Trade from", "Trade to" and "Travel Routes" should probably implement this feature.

In the case of FL:SR, there are only two categories of ships that have lower cruise speed than 500m/s (Battleships and Asteroid Miner at 400 and 300, respectively). But due to Liners, all 3 docking types including large moors do have at least one ship that can travel with the 500m/s cruise speed assumed as the cruise speed constant, so I suggest you do not have to worry about considering the trade route times to be different for the filter options.

[dd84ai]

Solved in #195