Ignore hash during callback URL check#2190
Open
herronjo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present, the library does not remove the URL hash when validating the redirectUrl, which means that all implicit grant callbacks fail unless
checkRedirectUrlWhenCheckingIfIsCallbackisfalsebecause the hash is still present in the checked URL (which is impossible to provide in the config redirectUrl, as they are dynamic values). This PR remediates this by stripping the hash from the URL during the check, where the URL parameters are removed.Also seems to automatically remove some stray carriage-returns in the UrlService tests, thanks auto-Prettier!